Change in coreboot[master]: Makefile: Move the .xcompile rule out of the if !NOCOMPILE block
Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34242 )
Change subject: Makefile: Move the .xcompile rule out of the if !NOCOMPILE block ......................................................................
Makefile: Move the .xcompile rule out of the if !NOCOMPILE block
Generating the .xcompile file should be possible even without a config.
BUG=b:112267918 TEST=Ran make and verified .xcompile was created
Change-Id: I8075f71e6e3e2c150378818eeff2858c36b35843 Signed-off-by: Raul E Rangel rrangel@chromium.org --- M Makefile 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/34242/1
diff --git a/Makefile b/Makefile index 45b0bc5..aaf43b4 100644 --- a/Makefile +++ b/Makefile @@ -129,6 +129,12 @@ endif endif
+.xcompile: util/xcompile/xcompile + rm -f $@ + $< $(XGCCPATH) > $@.tmp + \mv -f $@.tmp $@ 2> /dev/null + rm -f $@.tmp + ifeq ($(NOCOMPILE),1) include $(TOPLEVEL)/Makefile.inc include $(TOPLEVEL)/payloads/Makefile.inc @@ -147,12 +153,6 @@ # to silence stupid warnings about a file that would be generated anyway. $(if $(wildcard .xcompile)$(NOCOMPILE),,$(eval $(shell util/xcompile/xcompile $(XGCCPATH) > .xcompile || rm -f .xcompile)))
-.xcompile: util/xcompile/xcompile - rm -f $@ - $< $(XGCCPATH) > $@.tmp - \mv -f $@.tmp $@ 2> /dev/null - rm -f $@.tmp - -include .xcompile
ifneq ($(XCOMPILE_COMPLETE),1)
Hello build bot (Jenkins), Patrick Georgi, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34242
to look at the new patch set (#2).
Change subject: Makefile: Move the .xcompile rule out of the if !NOCOMPILE block ......................................................................
Makefile: Move the .xcompile rule out of the if !NOCOMPILE block
Generating the .xcompile file should be possible even without a config.
BUG=b:112267918 TEST=Ran make and verified .xcompile was created
Change-Id: I8075f71e6e3e2c150378818eeff2858c36b35843 Signed-off-by: Raul E Rangel rrangel@chromium.org --- M Makefile 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/34242/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34242 )
Change subject: Makefile: Move the .xcompile rule out of the if !NOCOMPILE block ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34242 )
Change subject: Makefile: Move the .xcompile rule out of the if !NOCOMPILE block ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34242 )
Change subject: Makefile: Move the .xcompile rule out of the if !NOCOMPILE block ......................................................................
Makefile: Move the .xcompile rule out of the if !NOCOMPILE block
Generating the .xcompile file should be possible even without a config.
BUG=b:112267918 TEST=Ran make and verified .xcompile was created
Change-Id: I8075f71e6e3e2c150378818eeff2858c36b35843 Signed-off-by: Raul E Rangel rrangel@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/34242 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Makefile 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Martin Roth: Looks good to me, approved
diff --git a/Makefile b/Makefile index 317a8eb..f0a22a5 100644 --- a/Makefile +++ b/Makefile @@ -129,6 +129,12 @@ endif endif
+.xcompile: util/xcompile/xcompile + rm -f $@ + $< $(XGCCPATH) > $@.tmp + \mv -f $@.tmp $@ 2> /dev/null + rm -f $@.tmp + -include $(TOPLEVEL)/site-local/Makefile.inc
ifeq ($(NOCOMPILE),1) @@ -148,12 +154,6 @@ # to silence stupid warnings about a file that would be generated anyway. $(if $(wildcard .xcompile)$(NOCOMPILE),,$(eval $(shell util/xcompile/xcompile $(XGCCPATH) > .xcompile || rm -f .xcompile)))
-.xcompile: util/xcompile/xcompile - rm -f $@ - $< $(XGCCPATH) > $@.tmp - \mv -f $@.tmp $@ 2> /dev/null - rm -f $@.tmp - -include .xcompile
ifneq ($(XCOMPILE_COMPLETE),1)
-
Martin Roth (Code Review) -
Patrick Georgi (Code Review)
-
Raul Rangel (Code Review)