Change in coreboot[master]: util/inteltool: add PCI ID for ICH10DO

[Idwer Vollering (Code Review)]

Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43321 )

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

util/inteltool: add PCI ID for ICH10DO

Change-Id: I3561679ef50f4c094d2503539074c957f759ecef
Signed-off-by: Idwer Vollering 
---
M util/inteltool/inteltool.h
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/43321/1

diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h
index b314fe4..f0a1eb3 100644
--- a/util/inteltool/inteltool.h
+++ b/util/inteltool/inteltool.h
@@ -74,6 +74,7 @@
 #define PCI_DEVICE_ID_INTEL_ICH9		0x2918
 #define PCI_DEVICE_ID_INTEL_ICH9M		0x2919
 #define PCI_DEVICE_ID_INTEL_ICH9ME		0x2917
+#define PCI_DEVICE_ID_INTEL_ICH10DO		0x3a14
 #define PCI_DEVICE_ID_INTEL_ICH10R		0x3a16
 #define PCI_DEVICE_ID_INTEL_ICH10               0x3a18
 #define PCI_DEVICE_ID_INTEL_3400_DESKTOP	0x3b00

[Idwer Vollering (Code Review)]

Hello Stefan Reinauer,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43321

to look at the new patch set (#2).

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

util/inteltool: add PCI ID for ICH10DO

Change-Id: I3561679ef50f4c094d2503539074c957f759ecef
Signed-off-by: Idwer Vollering 
---
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/43321/2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43321 )

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

Patch Set 2: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43321 )

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

Patch Set 2: Code-Review+1

I'd squash CB:43322 in here

[Idwer Vollering (Code Review)]

Hello build bot (Jenkins), Stefan Reinauer, Angel Pons, Kyösti Mälkki,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43321

to look at the new patch set (#3).

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

util/inteltool: add PCI ID for ICH10DO

Change-Id: I3561679ef50f4c094d2503539074c957f759ecef
Signed-off-by: Idwer Vollering 
---
M util/inteltool/gpio.c
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
M util/inteltool/powermgt.c
M util/inteltool/rootcmplx.c
M util/inteltool/spi.c
6 files changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/43321/3

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43321 )

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

Patch Set 3: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43321 )

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/43321/3/util/inteltool/spi.c 
File util/inteltool/spi.c:

https://review.coreboot.org/c/coreboot/+/43321/3/util/inteltool/spi.c@261 
PS3, Line 261: 	case PCI_DEVICE_ID_INTEL_ICH10:
Also here

[Idwer Vollering (Code Review)]

Hello build bot (Jenkins), Stefan Reinauer, Angel Pons, Kyösti Mälkki,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43321

to look at the new patch set (#4).

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

util/inteltool: add PCI ID for ICH10DO

Change-Id: I3561679ef50f4c094d2503539074c957f759ecef
Signed-off-by: Idwer Vollering 
---
M util/inteltool/gpio.c
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
M util/inteltool/powermgt.c
M util/inteltool/rootcmplx.c
M util/inteltool/spi.c
6 files changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/43321/4

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43321 )

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

Patch Set 4: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/43321/3/util/inteltool/spi.c 
File util/inteltool/spi.c:

https://review.coreboot.org/c/coreboot/+/43321/3/util/inteltool/spi.c@261 
PS3, Line 261: 	case PCI_DEVICE_ID_INTEL_ICH10:
> Also here

Done

[Idwer Vollering (Code Review)]

Idwer Vollering has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43321 )

Change subject: util/inteltool: add PCI ID for ICH10DO
......................................................................

util/inteltool: add PCI ID for ICH10DO

Change-Id: I3561679ef50f4c094d2503539074c957f759ecef
Signed-off-by: Idwer Vollering 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43321
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M util/inteltool/gpio.c
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
M util/inteltool/powermgt.c
M util/inteltool/rootcmplx.c
M util/inteltool/spi.c
6 files changed, 7 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/util/inteltool/gpio.c b/util/inteltool/gpio.c
index 911ec3c..b4f3eda 100644
--- a/util/inteltool/gpio.c
+++ b/util/inteltool/gpio.c
@@ -943,6 +943,7 @@
    	defaults_size = ARRAY_SIZE(pp_pch_mobile_defaults);
    	break;
    case PCI_DEVICE_ID_INTEL_ICH10:
+	case PCI_DEVICE_ID_INTEL_ICH10DO:
    case PCI_DEVICE_ID_INTEL_ICH10R:
    	gpiobase = pci_read_word(sb, 0x48) & 0xfffc;
    	gpio_registers = ich10_gpio_registers;
diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c
index 04e05dd..71b4bb0 100644
--- a/util/inteltool/inteltool.c
+++ b/util/inteltool/inteltool.c
@@ -137,6 +137,7 @@
    /* Southbridges (LPC controllers) */
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82371XX, "371AB/EB/MB" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10, "ICH10" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10DO, "ICH10DO" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH10R, "ICH10R" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9DH, "ICH9DH" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9DO, "ICH9DO" },
diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h
index b314fe4..f0a1eb3 100644
--- a/util/inteltool/inteltool.h
+++ b/util/inteltool/inteltool.h
@@ -74,6 +74,7 @@
 #define PCI_DEVICE_ID_INTEL_ICH9		0x2918
 #define PCI_DEVICE_ID_INTEL_ICH9M		0x2919
 #define PCI_DEVICE_ID_INTEL_ICH9ME		0x2917
+#define PCI_DEVICE_ID_INTEL_ICH10DO		0x3a14
 #define PCI_DEVICE_ID_INTEL_ICH10R		0x3a16
 #define PCI_DEVICE_ID_INTEL_ICH10               0x3a18
 #define PCI_DEVICE_ID_INTEL_3400_DESKTOP	0x3b00
diff --git a/util/inteltool/powermgt.c b/util/inteltool/powermgt.c
index a21d002..f4ebc5a 100644
--- a/util/inteltool/powermgt.c
+++ b/util/inteltool/powermgt.c
@@ -780,6 +780,7 @@
    	pm_registers_size = ARRAY_SIZE(lynxpoint_lp_pm_registers);
    	break;
    case PCI_DEVICE_ID_INTEL_ICH10:
+	case PCI_DEVICE_ID_INTEL_ICH10DO:
    case PCI_DEVICE_ID_INTEL_ICH10R:
    	pmbase = pci_read_word(sb, 0x40) & 0xff80;
    	pm_registers = ich10_pm_registers;
diff --git a/util/inteltool/rootcmplx.c b/util/inteltool/rootcmplx.c
index 490897f..b1e4939 100644
--- a/util/inteltool/rootcmplx.c
+++ b/util/inteltool/rootcmplx.c
@@ -29,6 +29,7 @@
    case PCI_DEVICE_ID_INTEL_ICH9M:
    case PCI_DEVICE_ID_INTEL_ICH9ME:
    case PCI_DEVICE_ID_INTEL_ICH10:
+	case PCI_DEVICE_ID_INTEL_ICH10DO:
    case PCI_DEVICE_ID_INTEL_ICH10R:
    case PCI_DEVICE_ID_INTEL_NM10:
    case PCI_DEVICE_ID_INTEL_I63XX:
diff --git a/util/inteltool/spi.c b/util/inteltool/spi.c
index 3d94c1f..ad16cb8 100644
--- a/util/inteltool/spi.c
+++ b/util/inteltool/spi.c
@@ -107,6 +107,7 @@
    case PCI_DEVICE_ID_INTEL_ICH9M:
    case PCI_DEVICE_ID_INTEL_ICH9ME:
    case PCI_DEVICE_ID_INTEL_ICH10:
+	case PCI_DEVICE_ID_INTEL_ICH10DO:
    case PCI_DEVICE_ID_INTEL_ICH10R:
    case PCI_DEVICE_ID_INTEL_NM10:
    	bios_cntl = pci_read_byte(sb, 0xdc);
@@ -258,6 +259,7 @@
    case PCI_DEVICE_ID_INTEL_ICH9M:
    case PCI_DEVICE_ID_INTEL_ICH9ME:
    case PCI_DEVICE_ID_INTEL_ICH10:
+	case PCI_DEVICE_ID_INTEL_ICH10DO:
    case PCI_DEVICE_ID_INTEL_ICH10R:
    case PCI_DEVICE_ID_INTEL_NM10:
    case PCI_DEVICE_ID_INTEL_I63XX: