Change in coreboot[master]: src/mainboard/hp/z220_sff_workstation/Kconfig: Add select MAINBOARD_U...
Ao Zhong has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48007 )
Change subject: src/mainboard/hp/z220_sff_workstation/Kconfig: Add select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
src/mainboard/hp/z220_sff_workstation/Kconfig: Add select MAINBOARD_USES_IFD_GBE_REGION
Add select MAINBOARD_USES_IFD_GBE_REGION to make CONFIG_HAVE_GBE_BIN (Add gigabit ethernet configuration) selection avaliable. Without that onboard Ethernet won't work.
Signed-off-by: Ao Zhong hacc1225@gmail.com Change-Id: I9fe138363fc47254285ebaa4a7dbe5b94a0a8784 --- M src/mainboard/hp/z220_sff_workstation/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48007/1
diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index b1cf89c..12643bd 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -18,6 +18,7 @@ select MAINBOARD_HAS_LIBGFXINIT select INTEL_GMA_HAVE_VBT select GFX_GMA_ANALOG_I2C_HDMI_B + select MAINBOARD_USES_IFD_GBE_REGION
config VBOOT select VBOOT_VBNV_CMOS
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48007 )
Change subject: src/mainboard/hp/z220_sff_workstation/Kconfig: Add select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/48007/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48007/1//COMMIT_MSG@7 PS1, Line 7: Add select replace with `Select`
https://review.coreboot.org/c/coreboot/+/48007/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard replace with `mb`
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48007
to look at the new patch set (#2).
Change subject: mb/hp/z220_sff_workstation/Kconfig: Add select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
mb/hp/z220_sff_workstation/Kconfig: Add select MAINBOARD_USES_IFD_GBE_REGION
Select MAINBOARD_USES_IFD_GBE_REGION to make CONFIG_HAVE_GBE_BIN (Add gigabit ethernet configuration) selection avaliable. Without that onboard Ethernet won't work.
Signed-off-by: Ao Zhong hacc1225@gmail.com Change-Id: I9fe138363fc47254285ebaa4a7dbe5b94a0a8784 --- M src/mainboard/hp/z220_sff_workstation/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48007/2
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48007
to look at the new patch set (#3).
Change subject: mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION
Select MAINBOARD_USES_IFD_GBE_REGION to make CONFIG_HAVE_GBE_BIN (Add gigabit ethernet configuration) selection avaliable. Without that onboard Ethernet won't work.
Signed-off-by: Ao Zhong hacc1225@gmail.com Change-Id: I9fe138363fc47254285ebaa4a7dbe5b94a0a8784 --- M src/mainboard/hp/z220_sff_workstation/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48007/3
Ao Zhong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48007 )
Change subject: mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48007/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48007/1//COMMIT_MSG@7 PS1, Line 7: Add select
replace with `Select`
Done
https://review.coreboot.org/c/coreboot/+/48007/1//COMMIT_MSG@7 PS1, Line 7: src/mainboard
replace with `mb`
Done
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48007 )
Change subject: mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48007/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48007/3//COMMIT_MSG@10 PS3, Line 10: avaliable ava*il*able
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48007
to look at the new patch set (#4).
Change subject: mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION
Select MAINBOARD_USES_IFD_GBE_REGION to make CONFIG_HAVE_GBE_BIN (Add gigabit ethernet configuration) selection available. Without that onboard Ethernet won't work.
Signed-off-by: Ao Zhong hacc1225@gmail.com Change-Id: I9fe138363fc47254285ebaa4a7dbe5b94a0a8784 --- M src/mainboard/hp/z220_sff_workstation/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/48007/4
Ao Zhong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48007 )
Change subject: mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48007/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/48007/3//COMMIT_MSG@10 PS3, Line 10: avaliable
ava*il*able
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48007 )
Change subject: mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
Patch Set 4: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48007 )
Change subject: mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION ......................................................................
mb/hp/z220_sff_workstation/Kconfig: Select MAINBOARD_USES_IFD_GBE_REGION
Select MAINBOARD_USES_IFD_GBE_REGION to make CONFIG_HAVE_GBE_BIN (Add gigabit ethernet configuration) selection available. Without that onboard Ethernet won't work.
Signed-off-by: Ao Zhong hacc1225@gmail.com Change-Id: I9fe138363fc47254285ebaa4a7dbe5b94a0a8784 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48007 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/hp/z220_sff_workstation/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Felix Singer: Looks good to me, but someone else must approve
diff --git a/src/mainboard/hp/z220_sff_workstation/Kconfig b/src/mainboard/hp/z220_sff_workstation/Kconfig index b1cf89c..12643bd 100644 --- a/src/mainboard/hp/z220_sff_workstation/Kconfig +++ b/src/mainboard/hp/z220_sff_workstation/Kconfig @@ -18,6 +18,7 @@ select MAINBOARD_HAS_LIBGFXINIT select INTEL_GMA_HAVE_VBT select GFX_GMA_ANALOG_I2C_HDMI_B + select MAINBOARD_USES_IFD_GBE_REGION
config VBOOT select VBOOT_VBNV_CMOS
-
Ao Zhong (Code Review) -
Felix Singer (Code Review)
-
Nico Huber (Code Review)