Attention is currently required from: Furquan Shaikh, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph.
Mariusz Szafrański has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57152 )
Change subject: soc/intel/denverton_ns: Ensure CPU device has a valid link
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Thanks for patch,
Could you also remove "device lapic 0 on end"
from mainboard/intel/harcuvar/devicetree.cb
(mainboard/scaleway/tagada/devicetree.cb ?)
in this patch to complete support for DNV SKUs
with BSP lapic_id !=0 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57152
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f453901b17f7eff22beed8dbf6995cdc9f9b776
Gerrit-Change-Number: 57152
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 26 Aug 2021 02:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment