Change in ...coreboot[master]: arch/riscv/Kconfig: Make correct default value for CONFIG_ARCH_RISCV_M
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33144
Change subject: arch/riscv/Kconfig: Make correct default value for CONFIG_ARCH_RISCV_M ......................................................................
arch/riscv/Kconfig: Make correct default value for CONFIG_ARCH_RISCV_M
Change-Id: Ib9329904060cab48d527de1b1ccdab5b6fe71b99 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/arch/riscv/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/33144/1
diff --git a/src/arch/riscv/Kconfig b/src/arch/riscv/Kconfig index 9d325af..25a3980 100644 --- a/src/arch/riscv/Kconfig +++ b/src/arch/riscv/Kconfig @@ -24,8 +24,8 @@ # one implementation that will not have it due # to security concerns. bool - default n if ARCH_RISCV_M_DISABLED - default y + default y if ARCH_RISCV && !ARCH_RISCV_M_DISABLED + default n
config ARCH_RISCV_S # S (supervisor) mode is for kernels. It is optional.
Hello Aaron Durbin, ron minnich, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33144
to look at the new patch set (#3).
Change subject: arch/riscv/Kconfig: Make correct default value for CONFIG_ARCH_RISCV_M ......................................................................
arch/riscv/Kconfig: Make correct default value for CONFIG_ARCH_RISCV_M
Change-Id: Ib9329904060cab48d527de1b1ccdab5b6fe71b99 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/arch/riscv/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/33144/3
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33144 )
Change subject: arch/riscv/Kconfig: Make correct default value for CONFIG_ARCH_RISCV_M ......................................................................
Patch Set 3: Code-Review+2
Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33144 )
Change subject: arch/riscv/Kconfig: Make correct default value for CONFIG_ARCH_RISCV_M ......................................................................
arch/riscv/Kconfig: Make correct default value for CONFIG_ARCH_RISCV_M
Change-Id: Ib9329904060cab48d527de1b1ccdab5b6fe71b99 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33144 Reviewed-by: Martin Roth martinroth@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/riscv/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/src/arch/riscv/Kconfig b/src/arch/riscv/Kconfig index 9d325af..25a3980 100644 --- a/src/arch/riscv/Kconfig +++ b/src/arch/riscv/Kconfig @@ -24,8 +24,8 @@ # one implementation that will not have it due # to security concerns. bool - default n if ARCH_RISCV_M_DISABLED - default y + default y if ARCH_RISCV && !ARCH_RISCV_M_DISABLED + default n
config ARCH_RISCV_S # S (supervisor) mode is for kernels. It is optional.
-
Martin Roth (Code Review) -
Subrata Banik (Code Review)