Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34141 )
Change subject: riscv: Remove unused header ......................................................................
riscv: Remove unused header
Change-Id: I4cd03e043e1bc2795b98d6ec2f88efa5b50d872b Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/riscv/stages.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34141/1
diff --git a/src/arch/riscv/stages.c b/src/arch/riscv/stages.c index 07b898f..9521e78 100644 --- a/src/arch/riscv/stages.c +++ b/src/arch/riscv/stages.c @@ -24,7 +24,6 @@ * linker script. */
-#include <arch/boot.h> #include <arch/encoding.h> #include <arch/stages.h> #include <arch/smp/smp.h>
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34141 )
Change subject: riscv: Remove unused header ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34141/1/src/arch/riscv/stages.c File src/arch/riscv/stages.c:
https://review.coreboot.org/c/coreboot/+/34141/1/src/arch/riscv/stages.c@27 PS1, Line 27: #include <arch/encoding.h> : #include <arch/stages.h> : #include <arch/smp/smp.h> : #include <rules.h> : #include <mcall.h> There is still one more include than external identifiers used in the code. So at least one more spurious include. Please clean it up at once.
Hello ron minnich, Jonathan Neuschäfer, build bot (Jenkins), Philipp Hug,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34141
to look at the new patch set (#2).
Change subject: riscv: Remove unused headers ......................................................................
riscv: Remove unused headers
Change-Id: I4cd03e043e1bc2795b98d6ec2f88efa5b50d872b Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/riscv/stages.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/34141/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34141 )
Change subject: riscv: Remove unused headers ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34141/1/src/arch/riscv/stages.c File src/arch/riscv/stages.c:
https://review.coreboot.org/c/coreboot/+/34141/1/src/arch/riscv/stages.c@27 PS1, Line 27: #include <arch/encoding.h> : #include <arch/stages.h> : #include <arch/smp/smp.h> : #include <rules.h> : #include <mcall.h>
There is still one more include than external identifiers used in the code. […]
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34141 )
Change subject: riscv: Remove unused headers ......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Don't want to bikeshed this further.
https://review.coreboot.org/c/coreboot/+/34141/1/src/arch/riscv/stages.c File src/arch/riscv/stages.c:
https://review.coreboot.org/c/coreboot/+/34141/1/src/arch/riscv/stages.c@27 PS1, Line 27: #include <arch/encoding.h> : #include <arch/stages.h> : #include <arch/smp/smp.h> : #include <rules.h> : #include <mcall.h>
Done
Ack
https://review.coreboot.org/c/coreboot/+/34141/2/src/arch/riscv/stages.c File src/arch/riscv/stages.c:
https://review.coreboot.org/c/coreboot/+/34141/2/src/arch/riscv/stages.c@29 PS2, Line 29: #include <rules.h> Seems unused.
https://review.coreboot.org/c/coreboot/+/34141/2/src/arch/riscv/stages.c@43 PS2, Line 43: main(); Indirectly included through <arch/stages.h>, I don't know why.
Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34141 )
Change subject: riscv: Remove unused headers ......................................................................
riscv: Remove unused headers
Change-Id: I4cd03e043e1bc2795b98d6ec2f88efa5b50d872b Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34141 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/arch/riscv/stages.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/arch/riscv/stages.c b/src/arch/riscv/stages.c index 07b898f..5b27508 100644 --- a/src/arch/riscv/stages.c +++ b/src/arch/riscv/stages.c @@ -24,8 +24,6 @@ * linker script. */
-#include <arch/boot.h> -#include <arch/encoding.h> #include <arch/stages.h> #include <arch/smp/smp.h> #include <rules.h>
-
Nico Huber (Code Review) -
Patrick Rudolph (Code Review)