Attention is currently required from: Andrey Petrov, Patrick Rudolph, HAOUAS Elyes.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61243 )
Change subject: soc/intel/apollolake: Convert to ASL 2.0
......................................................................
Patch Set 4:
(2 comments)
File src/soc/intel/apollolake/acpi/gpiolib.asl:
https://review.coreboot.org/c/coreboot/+/61243/comment/69bdd73d_71339717
PS4, Line 61: (Arg0 << 16) | CONFIG_PCR_BASE_ADDRESS
Wondering why do have used braces around the expression in one case and not in other line #61 vs #62?
https://review.coreboot.org/c/coreboot/+/61243/comment/95bc1b9d_102f6145
PS4, Line 82: Local1
Can't we replace Local1 with `CHSA(Arg1)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61243
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb362b5be05421b6ad2b2a3126c2943b7d55d135
Gerrit-Change-Number: 61243
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 03 Feb 2022 21:14:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment