Attention is currently required from: Lance Zhao, Philipp Hug, weidongwd, Tim Wawrzynczak, ron minnich.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74799 )
Change subject: ACPI,SMBIOS : Provide ACPI and SMBIOS supports for RISC-V ......................................................................
Patch Set 1:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74799/comment/ff7b38f5_1f78d450 PS1, Line 2: weidongwd Please configure your full name:
$ git config --global user.name "…" $ git commit --amend --author="… <…>" -s
https://review.coreboot.org/c/coreboot/+/74799/comment/a10087ba_c140bf22 PS1, Line 7: supports support
https://review.coreboot.org/c/coreboot/+/74799/comment/2c590303_8edaa59c PS1, Line 8:
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Please fix.
https://review.coreboot.org/c/coreboot/+/74799/comment/780b2483_691b0b16 PS1, Line 9: Adapts ACPI and SMBIOS related codes for RISC-V, and then passes their addresses to the OS via FDT. Please use imperative mood (present):
Adapt ACPI and SMBIOS related code for RISC-V, and then pass their addresses to the OS via FDT.
https://review.coreboot.org/c/coreboot/+/74799/comment/50d399cb_1c122e5e PS1, Line 10: I guess you should also elaborate a little more on the implementation. What is the difference to x86 for example.
https://review.coreboot.org/c/coreboot/+/74799/comment/0bac2a42_af90dbf7 PS1, Line 10: Please add a TEST= tag.
https://review.coreboot.org/c/coreboot/+/74799/comment/b3997047_464280b0 PS1, Line 11: weidongwd Ditto.