Attention is currently required from: Ariel Chang, Matt DeVillier, Nick Vaccaro, Paul Menzel, Paul Yang, Wayne3 Wang.
Ingo Reitz has posted comments on this change by Ingo Reitz. ( https://review.coreboot.org/c/coreboot/+/86026?usp=email )
Change subject: mb/google/volteer/drobit: fix power_limits_config
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86026/comment/c6bd280b_24f3c7d5?usp... :
PS4, Line 9: Drobit shows little power usage and very low clock speeds under load,
: despite being at very low temperatures. It turns out that
: power_limits_config is set to the lower end of the dptf power limit
: ranges as opposed to baseboard and other variants. This seems to
: prevent the device from using the intended power limits.
Commit a5761efd14a2 (mb/google/volteer/variants/drobit: Update DPTF parameters), decreased `. […]
i was unable to find any documentation on the changed values, but from what i observed the pl1 max value in line 82 (and 87 for pl2) seems to be overruled by power_limits_config, which made me question these 2 values in lines 82 and 87
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86026?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id0478c713b51db4972e7d93ec597a30fa885c22b
Gerrit-Change-Number: 86026
Gerrit-PatchSet: 4
Gerrit-Owner: Ingo Reitz
9l@9lo.re
Gerrit-Reviewer: Ariel Chang
ariel_chang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Yang
paul.f.yang@intel.corp-partner.google.com
Gerrit-Reviewer: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Attention: Paul Yang
paul.f.yang@intel.corp-partner.google.com
Gerrit-Attention: Ariel Chang
ariel_chang@pegatron.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 16 Jan 2025 22:45:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org