Change in coreboot[master]: mb/google/guybrush: Override I2C3 pad configuration - coreboot-gerrit

3 Jun 2021


      Attention is currently required from: Furquan Shaikh, Martin Roth, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55149 )
Change subject: mb/google/guybrush: Override I2C3 pad configuration
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/i2c.c:
https://review.coreboot.org/c/coreboot/+/55149/comment/36d6fc17_1cc42a1e 
PS1, Line 8: mainboard_i2c_override
...
What do you think about moving this to a devicetree config? That will eliminate the need for the cal […]
+1
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55149
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I595a64736fdac0274abffb68c5e521302275b845
Gerrit-Change-Number: 55149
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Thu, 03 Jun 2021 14:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment