Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79109?usp=email )
Change subject: mb/google/geralt: Remove unnecessary delay for MIPI panel ......................................................................
mb/google/geralt: Remove unnecessary delay for MIPI panel
According to eDP panel datasheet[1], the eDP panel needs 0 <= x <=200ms delay after VDD powering on. The MIPI panel[2] does not need this delay. Move this delay to eDP path.
[1] NE135FBM-N41 V8.0 Product Spec_P2 20191025.pdf [2] B5 TV110C9M-LL0 Product Specification Rev.P0
BRANCH=none BUG=none TEST=check FW screen TEST=check timestamp Before: 60:device initialization 696,422 (1) 15:starting LZMA decompress (ignore for x86) 696,587 (165) 16:finished LZMA decompress (ignore for x86) 696,675 (88) 17:starting LZ4 decompress (ignore for x86) 1,340,226 (643,551)
After: 60:device initialization 724,259 (1) 15:starting LZMA decompress (ignore for x86) 724,425 (166) 16:finished LZMA decompress (ignore for x86) 724,512 (87) 17:starting LZ4 decompress (ignore for x86) 1,168,176 (443,664)
Change-Id: I92bca5ec8269f4bad4dfab4ee193cdb5665de233 Signed-off-by: Yidi Lin yidilin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/79109 Reviewed-by: Ruihai Zhou zhouruihai@huaqin.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yu-Ping Wu yupingso@google.com Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: Paul Menzel paulepanter@mailbox.org --- M src/mainboard/google/geralt/display.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Paul Menzel: Looks good to me, but someone else must approve build bot (Jenkins): Verified Ruihai Zhou: Looks good to me, but someone else must approve Yu-Ping Wu: Looks good to me, approved Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/geralt/display.c b/src/mainboard/google/geralt/display.c index fa007a1..68a0a22 100644 --- a/src/mainboard/google/geralt/display.c +++ b/src/mainboard/google/geralt/display.c @@ -33,9 +33,9 @@ panel->power_on();
mtk_ddp_init(); - mdelay(200);
if (panel->disp_path == DISP_PATH_EDP) { + mdelay(200); if (mtk_edp_init(&edid) < 0) { printk(BIOS_ERR, "%s: Failed to initialize eDP\n", __func__); return -1;