Attention is currently required from: Martin Roth, Paul Fagerburg, Jan Dabros.
jacz@semihalf.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50305 )
Change subject: tests: Add lib/stack-test test case
......................................................................
Patch Set 4:
(1 comment)
File tests/lib/stack-test.c:
https://review.coreboot.org/c/coreboot/+/50305/comment/fc92ad97_25b841a5
PS1, Line 102: stack[i] = 0x42420707;
I agree, the stack is almost always an even number of machine words, often a power of 2. […]
Ok, I changed it back to previous form. Thank you :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50305
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf0cceac290618a50ecc4e65f1f9551dbf31bd32
Gerrit-Change-Number: 50305
Gerrit-PatchSet: 4
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Wed, 10 Feb 2021 10:16:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jacz@semihalf.com
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment