Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56325 )
Change subject: soc/intel/alderlake: Configure the SKU specific parameters for VR domains ......................................................................
Patch Set 4:
(4 comments)
File src/soc/intel/alderlake/vr_config.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124267): https://review.coreboot.org/c/coreboot/+/56325/comment/5cceaa42_d26cdfb4 PS4, Line 20: * | | GT | 3.2 | 3.2 | 50 | 57 | 28000 | please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124267): https://review.coreboot.org/c/coreboot/+/56325/comment/739e89e2_2f73054c PS4, Line 24: * | | GT | 3.2 | 3.2 | 50 | 40 | 28000 | please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124267): https://review.coreboot.org/c/coreboot/+/56325/comment/6e4ed5a8_5d55ccb8 PS4, Line 28: * | | GT | 3.2 | 3.2 | 40 | 20 | 28000 | please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-124267): https://review.coreboot.org/c/coreboot/+/56325/comment/d5fcf957_23877d60 PS4, Line 105: else { else should follow close brace '}'