Attention is currently required from: Alexander Couzens, Angel Pons, Charles Moyes, Felix Singer, Heiki Lõhmus, Kilian Neuner, Nico Huber, Paul Menzel, Xue Yao, insurgo@riseup.net.
Change subject: lenovo/x230: introduce FHD variant
......................................................................
By default, the nitrocaster mod requires [soldering an auxiliary power wire](https://nitrocaster. […]
In my opinion, this should be implemented as a separate patch as it touches the hardware beyond a simple VBT reconfiguration and might not work with every other mod. There's no way to know what it does without testing it on all eDP mods.
Not to mention that this is not the way nitrocaster's mod is intended to be installed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/28950?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 23
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Kilian Neuner
cb@9-r.net
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
rudolphpatrick05@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aleksei Kharlamov
dh@devass.club
Gerrit-CC: Charles Moyes
thechuckster@gmail.com
Gerrit-CC: Christian Herzog
Gerrit-CC: Heiki Lõhmus
h@lohmus.me
Gerrit-CC: Holger Levsen
holger@layer-acht.org
Gerrit-CC: Ivan V
ivv@i1v.org
Gerrit-CC: MartiniMoe
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Pavel Kovalenko
su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev
zl29ah@gmail.com
Gerrit-CC: Stanislaw Kaminski
stanislaw.kaminski@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Tom Hiller
thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: Xue Yao
xueyao@xyte.ch
Gerrit-CC: clayton craft
Gerrit-CC: insurgo@riseup.net
Gerrit-CC: nullmark
nullmark@googlemail.com
Gerrit-CC: slact
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Heiki Lõhmus
h@lohmus.me
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Xue Yao
xueyao@xyte.ch
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kilian Neuner
cb@9-r.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Charles Moyes
thechuckster@gmail.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: insurgo@riseup.net
Gerrit-Comment-Date: Sat, 03 Feb 2024 22:15:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Heiki Lõhmus
h@lohmus.me
Gerrit-MessageType: comment