Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55143 )
Change subject: soc/intel/alderlake: Set SaIpuEnable UPD from device state
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55143/comment/f93160d9_d22d034e
PS1, Line 214: m_cfg->SaIpuEnable
This check can be left as is, right? Since we have already evaluated the state of SA_DEVFN_IPU device on line 208?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53752f92c4b49093218cc34848727a72b63e84eb
Gerrit-Change-Number: 55143
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 19:19:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment