Change in coreboot[master]: mb/google/brask: Correct GPIO GPP_R6 and GPP_R7 setting - coreboot-gerrit

25 Oct 2021


      Attention is currently required from: David Wu, Paul Menzel, Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58578 )
Change subject: mb/google/brask: Correct GPIO GPP_R6 and GPP_R7 setting
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58578/comment/91eac5d3_bce7ce3d 
PS1, Line 9: Correct GPIO GPP_R6 and GPP_R7 setting to NF2 (DMIC_CLK1 and DMIC_DATA1).
...
Why is that correct (new schematics?)? What does it fix?
I think it was just confusion in the native function number for the DMIC
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58578
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3813306f8c7b69fe5cf0e188c55256b68d329ab
Gerrit-Change-Number: 58578
Gerrit-PatchSet: 1
Gerrit-Owner: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: David Wu david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee zhuohao@google.com
Gerrit-Attention: Alan Huang alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 19:31:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Gerrit-MessageType: comment