Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48580 )
Change subject: soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI ......................................................................
soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI
Remove the unused SOC_INTEL_COMMON_ACPI Kconfig option.
Change-Id: Id62cd44e0f7e4175ae65c9388569231d5c8c1fbc Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/soc/intel/common/Kconfig.common M src/soc/intel/common/acpi.h 2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/48580/1
diff --git a/src/soc/intel/common/Kconfig.common b/src/soc/intel/common/Kconfig.common index ba0b2db..eba33c7 100644 --- a/src/soc/intel/common/Kconfig.common +++ b/src/soc/intel/common/Kconfig.common @@ -57,10 +57,6 @@ default "3rdparty/blobs/soc/intel/kabylake/mma-blobs" if SOC_INTEL_KABYLAKE default "3rdparty/blobs/soc/intel/skylake/mma-blobs" if SOC_INTEL_SKYLAKE
-config SOC_INTEL_COMMON_ACPI - bool - default n - config SOC_INTEL_COMMON_NHLT bool default n diff --git a/src/soc/intel/common/acpi.h b/src/soc/intel/common/acpi.h index 5e38c4b..db12e81 100644 --- a/src/soc/intel/common/acpi.h +++ b/src/soc/intel/common/acpi.h @@ -16,4 +16,4 @@ */ int soc_fill_acpi_wake(uint32_t *pm1, uint32_t **gpe0);
-#endif /* CONFIG_SOC_INTEL_COMMON_ACPI */ +#endif /* _INTEL_COMMON_ACPI_H_ */
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48580 )
Change subject: soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48580/1/src/soc/intel/common/acpi.h File src/soc/intel/common/acpi.h:
https://review.coreboot.org/c/coreboot/+/48580/1/src/soc/intel/common/acpi.h... PS1, Line 19: _INTEL SOC_INTEL?
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48580 )
Change subject: soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI ......................................................................
Patch Set 1: Code-Review+1
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48580 )
Change subject: soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48580/1/src/soc/intel/common/acpi.h File src/soc/intel/common/acpi.h:
https://review.coreboot.org/c/coreboot/+/48580/1/src/soc/intel/common/acpi.h... PS1, Line 19: _INTEL
SOC_INTEL?
It matches the define above.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48580 )
Change subject: soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48580/1/src/soc/intel/common/acpi.h File src/soc/intel/common/acpi.h:
https://review.coreboot.org/c/coreboot/+/48580/1/src/soc/intel/common/acpi.h... PS1, Line 19: _INTEL
It matches the define above.
Ack
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48580 )
Change subject: soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI ......................................................................
Patch Set 1: Code-Review+2
Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48580 )
Change subject: soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI ......................................................................
soc/intel/common: Remove unused SOC_INTEL_COMMON_ACPI
Remove the unused SOC_INTEL_COMMON_ACPI Kconfig option.
Change-Id: Id62cd44e0f7e4175ae65c9388569231d5c8c1fbc Signed-off-by: Marc Jones marcjones@sysproconsulting.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48580 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Benjamin Doron benjamin.doron00@gmail.com Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/Kconfig.common M src/soc/intel/common/acpi.h 2 files changed, 1 insertion(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Benjamin Doron: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/common/Kconfig.common b/src/soc/intel/common/Kconfig.common index 1a59d04..b0fbf25 100644 --- a/src/soc/intel/common/Kconfig.common +++ b/src/soc/intel/common/Kconfig.common @@ -58,10 +58,6 @@ default "3rdparty/blobs/soc/intel/kabylake/mma-blobs" if SOC_INTEL_KABYLAKE default "3rdparty/blobs/soc/intel/skylake/mma-blobs" if SOC_INTEL_SKYLAKE
-config SOC_INTEL_COMMON_ACPI - bool - default n - config SOC_INTEL_COMMON_NHLT bool default n diff --git a/src/soc/intel/common/acpi.h b/src/soc/intel/common/acpi.h index 5e38c4b..db12e81 100644 --- a/src/soc/intel/common/acpi.h +++ b/src/soc/intel/common/acpi.h @@ -16,4 +16,4 @@ */ int soc_fill_acpi_wake(uint32_t *pm1, uint32_t **gpe0);
-#endif /* CONFIG_SOC_INTEL_COMMON_ACPI */ +#endif /* _INTEL_COMMON_ACPI_H_ */
-
Benjamin Doron (Code Review) -
Furquan Shaikh (Code Review)
-
Marc Jones (Code Review)