Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/29511
Change subject: mb/{lenovo/x201,packardbell/ms2290}/romstage: Fix comments ......................................................................
mb/{lenovo/x201,packardbell/ms2290}/romstage: Fix comments
RCBA address numbers in comments looks wrong and confusing. Let's fix them.
This is a cosmetic change since no actual data is added or removed.
Change-Id: I0e521acdac17959586bc0af7d8a2f7182f1e6721 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/x201/romstage.c M src/mainboard/packardbell/ms2290/romstage.c 2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/29511/1
diff --git a/src/mainboard/lenovo/x201/romstage.c b/src/mainboard/lenovo/x201/romstage.c index cfa11b4..5e9937f 100644 --- a/src/mainboard/lenovo/x201/romstage.c +++ b/src/mainboard/lenovo/x201/romstage.c @@ -121,8 +121,6 @@ /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, - /* 3600 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3610 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -132,12 +130,14 @@ /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36b0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, - /* 36c0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, - /* 36d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, + /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3710 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, + /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, }; unsigned i; for (i = 0; i < sizeof(rcba_dump3) / 4; i++) { diff --git a/src/mainboard/packardbell/ms2290/romstage.c b/src/mainboard/packardbell/ms2290/romstage.c index 56f11a1..ae48b90 100644 --- a/src/mainboard/packardbell/ms2290/romstage.c +++ b/src/mainboard/packardbell/ms2290/romstage.c @@ -116,8 +116,6 @@ /* 35f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3600 */ 0x0a001f00, 0x00000000, 0x00000000, 0x00000001, /* 3610 */ 0x00010000, 0x00000000, 0x00000000, 0x00000000, - /* 3600 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3610 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3620 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3630 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3640 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, @@ -127,12 +125,14 @@ /* 3680 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 3690 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, /* 36a0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36b0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, - /* 36c0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, - /* 36d0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 36e0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36b0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36c0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 36d0 */ 0x00000000, 0x089c0018, 0x00000000, 0x00000000, + /* 36e0 */ 0x11111111, 0x00000000, 0x00000000, 0x00000000, /* 36f0 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, - /* 3710 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, + /* 3700 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 3710 */ 0x00000000, 0x00000000, 0x00000000, 0x00000000, + /* 3720 */ 0x00000000, 0x4e564d49, 0x00000000, 0x00000000, }; unsigned i;
-
Peter Lemenkov (Code Review)