Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jon Murphy, Karthik Ramasubramanian, Matt DeVillier.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78233?usp=email )
Change subject: soc/amd/phoenix: Add build rules to enable CBFS verification
......................................................................
Patch Set 2:
(2 comments)
File src/soc/amd/phoenix/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/78233/comment/01287176_150e7975 :
PS2, Line 49: # 0x80 accounts for the cbfs_file struct + filename + metadata structs, aligned to 64 bytes
: # Building the cbfs image will fail if the offset isn't large enough
: AMD_FW_AB_POSITION := 0x80
Should we change this for all platforms AMD by checking if cbfs verification is enabled?
https://review.coreboot.org/c/coreboot/+/78233/comment/42cd130a_b51920f4 :
PS2, Line 346:
Do we need to add the key signature block as well, or is that already done by default?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78233?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibfffd3d6fce8b80ec156a7b13b387e1df8c43347
Gerrit-Change-Number: 78233
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 16 Oct 2023 18:46:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment