Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Angel Pons, Andrey Petrov, Patrick Rudolph.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55853 )
Change subject: arch/x86: Add X86_CUSTOM_BOOTMEDIA
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/55853/comment/70a28c15_3a9a26a8
PS1, Line 126: this option
Nit: This is probably fine, but you might want to make this specific:
Turning on X86_CUSTOM_BOOTMEDIA disables X86_TOP4G_BOOTMEDIA_MAP which allows
SoC code to provide acustom mmap_boot.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55853
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65bbc118bde88687a7d7749c87acf1cbdc56a269
Gerrit-Change-Number: 55853
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 01 Jul 2021 17:17:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment