Attention is currently required from: Arthur Heymans, Jonathan Zhang, Lance Zhao, Rocky Phagura, Tim Wawrzynczak.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77416?usp=email )
Change subject: acpi: Move EINJ code to vendorcode/ocp
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/77416/comment/1b9e784f_e6ddbd8f :
PS3, Line 7: acpi: Move EINJ code to vendorcode/ocp
So some technical insight. The code in acpi. […]
They *could* stay, but there's no reason to keep them if we're moving everything else out. We wouldn't implement header files for random tables that weren't actually implemented in coreboot, so I'd argue these shouldn't be left in the main ACPI header file.
Unrelated to this patch, I'd actually like to split up the main acpi.h file into the separate tables. It's gotten too large IMO.
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/77416/comment/acd74d24_821f38b7 :
PS3, Line 78: EINJ
should we keep this here ?
Yes, that must remain. It's just a value in an enum though, so it doesn't do anything if it's not used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77416?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e91b0730cf3fcef0c54c513181c973bfe18bacf
Gerrit-Change-Number: 77416
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 19 Nov 2023 02:52:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr
Gerrit-MessageType: comment