Change in coreboot[master]: src/Kconfig: Drop unused DEBUG_ACPI

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

31 Oct 2019 31 Oct '19

7:47 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36498 )

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

src/Kconfig: Drop unused DEBUG_ACPI

Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/Kconfig 1 file changed, 0 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36498/1

diff --git a/src/Kconfig b/src/Kconfig index 2b41ff2..defe4e4 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -828,17 +828,6 @@

# Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional # printk(BIOS_DEBUG, ...) calls. -config DEBUG_ACPI - prompt "Output verbose ACPI debug messages" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 - bool - default n - help - This option enables additional ACPI related debug messages. - - Note: This option will slightly increase the size of the coreboot image. - - If unsure, say N. - config DEBUG_CONSOLE_INIT bool "Debug console initialisation code" default n

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Nico Huber (Code Review)

31 Oct 31 Oct

1:51 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36498 )

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

Patch Set 1:

(1 comment)

There are several files in configs/ that should be updated.

https://review.coreboot.org/c/coreboot/+/36498/1/src/Kconfig File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/36498/1/src/Kconfig@829 PS1, Line 829: # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional : # printk(BIOS_DEBUG, ...) calls. drop?

-- To view, visit https://review.coreboot.org/c/coreboot/+/36498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Gerrit-Change-Number: 36498 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 31 Oct 2019 13:51:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2:25 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36498

to look at the new patch set (#2).

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

src/Kconfig: Drop unused DEBUG_ACPI

Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/Kconfig 1 file changed, 0 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36498/2

HAOUAS Elyes (Code Review)

2:54 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36498 )

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

Patch Set 2:

(1 comment)

Dankeschön

https://review.coreboot.org/c/coreboot/+/36498/1/src/Kconfig File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/36498/1/src/Kconfig@829 PS1, Line 829: # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional : # printk(BIOS_DEBUG, ...) calls.

...

drop?

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/36498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Gerrit-Change-Number: 36498 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 31 Oct 2019 14:54:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nico Huber (Code Review)

4 Nov 4 Nov

1:22 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36498 )

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

Patch Set 2:

(1 comment)

Please also remove CONFIG_DEBUG_ACPI from `configs/*`.

https://review.coreboot.org/c/coreboot/+/36498/1/src/Kconfig File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/36498/1/src/Kconfig@829 PS1, Line 829: # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional : # printk(BIOS_DEBUG, ...) calls.

...

Ack

That was the wrong one.

-- To view, visit https://review.coreboot.org/c/coreboot/+/36498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Gerrit-Change-Number: 36498 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 Nov 2019 13:22:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2:04 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36498 )

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

Patch Set 2:

(1 comment)

Thank you

https://review.coreboot.org/c/coreboot/+/36498/1/src/Kconfig File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/36498/1/src/Kconfig@829 PS1, Line 829: # Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional : # printk(BIOS_DEBUG, ...) calls.

...

That was the wrong one.

lol

-- To view, visit https://review.coreboot.org/c/coreboot/+/36498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Gerrit-Change-Number: 36498 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 Nov 2019 14:04:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

2:04 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36498

to look at the new patch set (#3).

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

src/Kconfig: Drop unused DEBUG_ACPI

Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/Kconfig 1 file changed, 0 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36498/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/36498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Gerrit-Change-Number: 36498 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

2:13 p.m.

Hello build bot (Jenkins), Nico Huber,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/36498

to look at the new patch set (#4).

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

src/Kconfig: Drop unused DEBUG_ACPI

Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M configs/config.emulation_qemu_x86_i440fx_debug M configs/config.lenovo_t400_vboot_and_debug M configs/config.lenovo_x201_all_debug_option_table_bt_on_wifi M src/Kconfig 4 files changed, 0 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/36498/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/36498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Gerrit-Change-Number: 36498 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Nico Huber (Code Review)

2:26 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36498 )

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/36498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Gerrit-Change-Number: 36498 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 04 Nov 2019 14:26:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5 Nov 5 Nov

2:58 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36498 )

Change subject: src/Kconfig: Drop unused DEBUG_ACPI ......................................................................

src/Kconfig: Drop unused DEBUG_ACPI

Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36498 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M configs/config.emulation_qemu_x86_i440fx_debug M configs/config.lenovo_t400_vboot_and_debug M configs/config.lenovo_x201_all_debug_option_table_bt_on_wifi M src/Kconfig 4 files changed, 0 insertions(+), 16 deletions(-)

Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved

diff --git a/configs/config.emulation_qemu_x86_i440fx_debug b/configs/config.emulation_qemu_x86_i440fx_debug index ffca28b..011f163 100644 --- a/configs/config.emulation_qemu_x86_i440fx_debug +++ b/configs/config.emulation_qemu_x86_i440fx_debug @@ -4,7 +4,6 @@ CONFIG_DEBUG_CBFS=y CONFIG_DEBUG_PIRQ=y CONFIG_DEBUG_MALLOC=y -CONFIG_DEBUG_ACPI=y CONFIG_TRACE=y CONFIG_DEBUG_BOOT_STATE=y CONFIG_DEBUG_ADA_CODE=y diff --git a/configs/config.lenovo_t400_vboot_and_debug b/configs/config.lenovo_t400_vboot_and_debug index 5a1add6..2923f94 100644 --- a/configs/config.lenovo_t400_vboot_and_debug +++ b/configs/config.lenovo_t400_vboot_and_debug @@ -8,7 +8,6 @@ CONFIG_DEBUG_SMBUS=y CONFIG_DEBUG_SMI=y CONFIG_DEBUG_MALLOC=y -CONFIG_DEBUG_ACPI=y CONFIG_DEBUG_BOOT_STATE=y CONFIG_DEBUG_ADA_CODE=y CONFIG_H8_FN_KEY_AS_VBOOT_RECOVERY_SW=y diff --git a/configs/config.lenovo_x201_all_debug_option_table_bt_on_wifi b/configs/config.lenovo_x201_all_debug_option_table_bt_on_wifi index 1579aa3..a75d91a 100644 --- a/configs/config.lenovo_x201_all_debug_option_table_bt_on_wifi +++ b/configs/config.lenovo_x201_all_debug_option_table_bt_on_wifi @@ -7,7 +7,6 @@ CONFIG_DEBUG_SMBUS=y CONFIG_DEBUG_SMI=y CONFIG_DEBUG_MALLOC=y -CONFIG_DEBUG_ACPI=y CONFIG_DEBUG_SPI_FLASH=y CONFIG_DEBUG_BOOT_STATE=y CONFIG_DEBUG_ADA_CODE=y diff --git a/src/Kconfig b/src/Kconfig index 793927a..0d56291 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -840,19 +840,6 @@

If unsure, say N.

-# Only visible if debug level is DEBUG (7) or SPEW (8) as it does additional -# printk(BIOS_DEBUG, ...) calls. -config DEBUG_ACPI - prompt "Output verbose ACPI debug messages" if DEFAULT_CONSOLE_LOGLEVEL_7 || DEFAULT_CONSOLE_LOGLEVEL_8 - bool - default n - help - This option enables additional ACPI related debug messages. - - Note: This option will slightly increase the size of the coreboot image. - - If unsure, say N. - config DEBUG_CONSOLE_INIT bool "Debug console initialisation code" default n

-- To view, visit https://review.coreboot.org/c/coreboot/+/36498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I135f3e6ec5e75df03331c0c46edb0be243af2adb Gerrit-Change-Number: 36498 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1791

days inactive

1796

days old

coreboot-gerrit@coreboot.org

9 comments

3 participants

tags (0)

participants (3)

HAOUAS Elyes (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)