Change in coreboot[master]: drivers/nvidia/optimus: Write _ROM method - coreboot-gerrit

7 Aug 2020


      Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43074 )
Change subject: drivers/nvidia/optimus: Write _ROM method
......................................................................
Patch Set 4:
...
Please explain why this is needed. The generic PCI driver should already do the same.
1. Without an ACPI name declared, a scope cannot be written to the device.
2. Are you referring to device/pci_device.c? I see that it should call `pci_rom_ssdt`, but it hadn't been successful for me. Possibly due to 1? (or in my case, CB:43070. I'll test again.)
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/43074
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida87aebf8fdf341ab350c2bb3704d2ef695cf8f0
Gerrit-Change-Number: 43074
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jeremy Soller jeremy@system76.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Prasun Gera
Gerrit-Comment-Date: Fri, 07 Aug 2020 04:15:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment