Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Menzel, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51446 )
Change subject: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51446/comment/e4da8726_23d8d572
PS4, Line 8:
I like timestamps. ;-) […]
It's SoC-specific because it depends on CSE/FSP support.
File src/soc/intel/alderlake/telemetry.c:
https://review.coreboot.org/c/coreboot/+/51446/comment/e6b363c0_29e3fe53
PS4, Line 109: printk(BIOS_DEBUG, "ME_BIOS_PAYLOAD_HOB missing!\n");
Sounds like an error to me?
Since this HOB is only used to obtain timestamps of pre-reset events, I'd rather use BIOS_WARNING or BIOS_NOTICE. I imagine the HOB may not be present in some cases, e.g. if CSE isn't operational, thus I'd go with BIOS_NOTICE (Unexpected but relatively insignificant).
Note: CSE not working properly is a more serious issue, but this would be logged from CSE code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b7728d3da0d38dc0f1b465743486025dcf354b3
Gerrit-Change-Number: 51446
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 19 Mar 2021 13:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment