[coreboot-gerrit] Change in coreboot[master]: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table

[Angel Pons (Code Review)]

Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Menzel, Subrata Banik, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51446 )

Change subject: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table
......................................................................

Patch Set 4:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/51446/comment/e4da8726_23d8d572 
PS4, Line 8:
> I like timestamps. ;-) […]

It's SoC-specific because it depends on CSE/FSP support.

File src/soc/intel/alderlake/telemetry.c:

https://review.coreboot.org/c/coreboot/+/51446/comment/e6b363c0_29e3fe53 
PS4, Line 109: 	printk(BIOS_DEBUG, "ME_BIOS_PAYLOAD_HOB missing!\n");
> Sounds like an error to me?

Since this HOB is only used to obtain timestamps of pre-reset events, I'd rather use BIOS_WARNING or BIOS_NOTICE. I imagine the HOB may not be present in some cases, e.g. if CSE isn't operational, thus I'd go with BIOS_NOTICE (Unexpected but relatively insignificant).

Note: CSE not working properly is a more serious issue, but this would be logged from CSE code.