Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Menzel, Subrata Banik, Patrick Rudolph.

View Change

2 comments:

• Commit Message:

  • Patch Set #4, Line 8:

    I like timestamps. ;-) […]

    It's SoC-specific because it depends on CSE/FSP support.

• File src/soc/intel/alderlake/telemetry.c:

  • Patch Set #4, Line 109: printk(BIOS_DEBUG, "ME_BIOS_PAYLOAD_HOB missing!\n");

    Sounds like an error to me?

    Since this HOB is only used to obtain timestamps of pre-reset events, I'd rather use BIOS_WARNING or BIOS_NOTICE. I imagine the HOB may not be present in some cases, e.g. if CSE isn't operational, thus I'd go with BIOS_NOTICE (Unexpected but relatively insignificant).

    Note: CSE not working properly is a more serious issue, but this would be logged from CSE code.

To view, visit change 51446. To unsubscribe, or for help writing mail filters, visit settings.