Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72659 )
Change subject: soc/amd: Use common reset code for PCO, CZN, MDN, PHX & Glinda
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
i'd split this patch into two halves: one for picasso, cezanne and mendocino that doesn't change behavior and one for phenix and glinda that changes behavior. or have one patch change to use the common code and another one to change behavior on phoenix and glinda. mixing cleanups/code improvements with functional changes in one patch makes the very unlikely case of the need for a revert more difficult. apart from that, i like the patch
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72659
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie05c790573e4e68f3ec91bacffcc7d7efb986d79
Gerrit-Change-Number: 72659
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 02 Feb 2023 14:09:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment