Attention is currently required from: Jason Glenesk, Marshall Dawson, Matt Papageorge.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51956 )
Change subject: mb/amd/majolica: add DXIO and DDI descriptors
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/amd/majolica/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/51956/comment/91332fb0_e27d4a22
PS3, Line 12: device_number = 2
- […]
haven't checked if that's correct for the mainboard, but this should indeed be on device 1, since it's on the GPU lanes
https://review.coreboot.org/c/coreboot/+/51956/comment/a43d574a_7c45812a
PS3, Line 23: device_number = 1,
- […]
yes, this should be behind some function of device 2 on bus 0. probably same for the next one
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51956
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65c7e0ebf1e43fd4608d46bae8a176cfc3d0236b
Gerrit-Change-Number: 51956
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Comment-Date: Wed, 31 Mar 2021 21:37:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-MessageType: comment