Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38905 )
Change subject: mainboard: drop 5 broken ROMCC_BOOTBLOCK boards ......................................................................
mainboard: drop 5 broken ROMCC_BOOTBLOCK boards
The source code of these 5 boards can't be successfully built after a simple switch away from ROMCC_BOOTBLOCK which we did for many other AMD boards. See my failed attempts at CB:37976, CB:37979, CB:37980, CB:37981 and CB:37982. Unless someone is really interested in fixing and if their code doesn't hold any other value, they could be dropped.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ia62c15a565f0284525b4e1856f7c430b733bf178 --- D src/mainboard/amd/bettong/BiosCallOuts.c D src/mainboard/amd/bettong/BiosCallOuts.h D src/mainboard/amd/bettong/Kconfig D src/mainboard/amd/bettong/Kconfig.name D src/mainboard/amd/bettong/Makefile.inc D src/mainboard/amd/bettong/OemCustomize.c D src/mainboard/amd/bettong/README D src/mainboard/amd/bettong/acpi/carrizo_fch.asl D src/mainboard/amd/bettong/acpi/gpe.asl D src/mainboard/amd/bettong/acpi/mainboard.asl D src/mainboard/amd/bettong/acpi/routing.asl D src/mainboard/amd/bettong/acpi/sleep.asl D src/mainboard/amd/bettong/acpi/usb_oc.asl D src/mainboard/amd/bettong/acpi_tables.c D src/mainboard/amd/bettong/board_info.txt D src/mainboard/amd/bettong/boardid.c D src/mainboard/amd/bettong/cmos.layout D src/mainboard/amd/bettong/devicetree.cb D src/mainboard/amd/bettong/dsdt.asl D src/mainboard/amd/bettong/fchec.c D src/mainboard/amd/bettong/irq_tables.c D src/mainboard/amd/bettong/mainboard.c D src/mainboard/amd/bettong/mptable.c D src/mainboard/amd/bettong/romstage.c D src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c D src/mainboard/amd/db-ft3b-lc/Kconfig D src/mainboard/amd/db-ft3b-lc/Kconfig.name D src/mainboard/amd/db-ft3b-lc/Makefile.inc D src/mainboard/amd/db-ft3b-lc/Memphis_MEM4G16D3EABG.spd.hex D src/mainboard/amd/db-ft3b-lc/OemCustomize.c D src/mainboard/amd/db-ft3b-lc/acpi/gpe.asl D src/mainboard/amd/db-ft3b-lc/acpi/ide.asl D src/mainboard/amd/db-ft3b-lc/acpi/mainboard.asl D src/mainboard/amd/db-ft3b-lc/acpi/routing.asl D src/mainboard/amd/db-ft3b-lc/acpi/si.asl D src/mainboard/amd/db-ft3b-lc/acpi/sleep.asl D src/mainboard/amd/db-ft3b-lc/acpi/thermal.asl D src/mainboard/amd/db-ft3b-lc/acpi/usb_oc.asl D src/mainboard/amd/db-ft3b-lc/acpi_tables.c D src/mainboard/amd/db-ft3b-lc/board_info.txt D src/mainboard/amd/db-ft3b-lc/cmos.layout D src/mainboard/amd/db-ft3b-lc/devicetree.cb D src/mainboard/amd/db-ft3b-lc/dsdt.asl D src/mainboard/amd/db-ft3b-lc/irq_tables.c D src/mainboard/amd/db-ft3b-lc/mainboard.c D src/mainboard/amd/db-ft3b-lc/mptable.c D src/mainboard/amd/db-ft3b-lc/romstage.c D src/mainboard/amd/lamar/BiosCallOuts.c D src/mainboard/amd/lamar/Kconfig D src/mainboard/amd/lamar/Kconfig.name D src/mainboard/amd/lamar/Makefile.inc D src/mainboard/amd/lamar/OemCustomize.c D src/mainboard/amd/lamar/acpi/gpe.asl D src/mainboard/amd/lamar/acpi/mainboard.asl D src/mainboard/amd/lamar/acpi/routing.asl D src/mainboard/amd/lamar/acpi/si.asl D src/mainboard/amd/lamar/acpi/sleep.asl D src/mainboard/amd/lamar/acpi/thermal.asl D src/mainboard/amd/lamar/acpi/usb_oc.asl D src/mainboard/amd/lamar/acpi_tables.c D src/mainboard/amd/lamar/board_info.txt D src/mainboard/amd/lamar/cmos.layout D src/mainboard/amd/lamar/devicetree.cb D src/mainboard/amd/lamar/dsdt.asl D src/mainboard/amd/lamar/irq_tables.c D src/mainboard/amd/lamar/mainboard.c D src/mainboard/amd/lamar/mptable.c D src/mainboard/amd/lamar/romstage.c D src/mainboard/amd/olivehillplus/BiosCallOuts.c D src/mainboard/amd/olivehillplus/Kconfig D src/mainboard/amd/olivehillplus/Kconfig.name D src/mainboard/amd/olivehillplus/Makefile.inc D src/mainboard/amd/olivehillplus/OemCustomize.c D src/mainboard/amd/olivehillplus/acpi/gpe.asl D src/mainboard/amd/olivehillplus/acpi/ide.asl D src/mainboard/amd/olivehillplus/acpi/mainboard.asl D src/mainboard/amd/olivehillplus/acpi/routing.asl D src/mainboard/amd/olivehillplus/acpi/si.asl D src/mainboard/amd/olivehillplus/acpi/sleep.asl D src/mainboard/amd/olivehillplus/acpi/thermal.asl D src/mainboard/amd/olivehillplus/acpi/usb_oc.asl D src/mainboard/amd/olivehillplus/acpi_tables.c D src/mainboard/amd/olivehillplus/board_info.txt D src/mainboard/amd/olivehillplus/cmos.layout D src/mainboard/amd/olivehillplus/devicetree.cb D src/mainboard/amd/olivehillplus/dsdt.asl D src/mainboard/amd/olivehillplus/irq_tables.c D src/mainboard/amd/olivehillplus/mainboard.c D src/mainboard/amd/olivehillplus/mptable.c D src/mainboard/amd/olivehillplus/romstage.c D src/mainboard/bap/ode_e21XX/BAP_Q7_1066.spd.hex D src/mainboard/bap/ode_e21XX/BAP_Q7_1333.spd.hex D src/mainboard/bap/ode_e21XX/BAP_Q7_800.spd.hex D src/mainboard/bap/ode_e21XX/BiosCallOuts.c D src/mainboard/bap/ode_e21XX/Kconfig D src/mainboard/bap/ode_e21XX/Kconfig.name D src/mainboard/bap/ode_e21XX/Makefile.inc D src/mainboard/bap/ode_e21XX/OemCustomize.c D src/mainboard/bap/ode_e21XX/acpi/gpe.asl D src/mainboard/bap/ode_e21XX/acpi/ide.asl D src/mainboard/bap/ode_e21XX/acpi/mainboard.asl D src/mainboard/bap/ode_e21XX/acpi/routing.asl D src/mainboard/bap/ode_e21XX/acpi/si.asl D src/mainboard/bap/ode_e21XX/acpi/sleep.asl D src/mainboard/bap/ode_e21XX/acpi/superio.asl D src/mainboard/bap/ode_e21XX/acpi/thermal.asl D src/mainboard/bap/ode_e21XX/acpi/usb_oc.asl D src/mainboard/bap/ode_e21XX/acpi_tables.c D src/mainboard/bap/ode_e21XX/board_info.txt D src/mainboard/bap/ode_e21XX/cmos.layout D src/mainboard/bap/ode_e21XX/devicetree.cb D src/mainboard/bap/ode_e21XX/dsdt.asl D src/mainboard/bap/ode_e21XX/irq_tables.c D src/mainboard/bap/ode_e21XX/mainboard.c D src/mainboard/bap/ode_e21XX/mptable.c D src/mainboard/bap/ode_e21XX/romstage.c 116 files changed, 0 insertions(+), 9,893 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/38905/1
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38905 )
Change subject: mainboard: drop 5 broken ROMCC_BOOTBLOCK boards ......................................................................
Patch Set 1:
Hope you'd like this ;-)
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38905 )
Change subject: mainboard: drop 5 broken ROMCC_BOOTBLOCK boards ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38905 )
Change subject: mainboard: drop 5 broken ROMCC_BOOTBLOCK boards ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38905/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38905/1//COMMIT_MSG@7 PS1, Line 7: broken unmaintained
https://review.coreboot.org/c/coreboot/+/38905/1//COMMIT_MSG@9 PS1, Line 9: The source code of these 5 boards can't be successfully built after a : simple switch away from ROMCC_BOOTBLOCK which we did for many other : AMD boards. See my failed attempts at CB:37976, CB:37979, CB:37980, : CB:37981 and CB:37982. Unless someone is really interested in fixing : and if their code doesn't hold any other value, they could be dropped. remove
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38905 )
Change subject: mainboard: drop 5 broken ROMCC_BOOTBLOCK boards ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38905/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38905/1//COMMIT_MSG@7 PS1, Line 7: broken
unmaintained
"Unmaintained" isn't a good enough reason for removal: there's always a chance someone stumbles upon a board, discovers that it's supported by coreboot (of course if it hasn't been dropped!) and joins us - maybe helping with the common code as well (btw, G505S and AM1I-A technically were unmaintained before I signed up as their maintainer). Meanwhile, "broken" is a much stronger reason: if we couldn't get them built in a reasonable time, means a newcomer would fail as well - so no benefit of keeping them aside for the reference.
https://review.coreboot.org/c/coreboot/+/38905/1//COMMIT_MSG@9 PS1, Line 9: The source code of these 5 boards can't be successfully built after a : simple switch away from ROMCC_BOOTBLOCK which we did for many other : AMD boards. See my failed attempts at CB:37976, CB:37979, CB:37980, : CB:37981 and CB:37982. Unless someone is really interested in fixing : and if their code doesn't hold any other value, they could be dropped.
remove
I needed to provide an explanation why I remove these 5 boards but not removing the others.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38905 )
Change subject: mainboard: drop 5 broken ROMCC_BOOTBLOCK boards ......................................................................
Patch Set 1:
For easy “revertability”, please make one commit per board.
HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/38905 )
Change subject: mainboard: drop 5 broken ROMCC_BOOTBLOCK boards ......................................................................
Removed Code-Review+2 by HAOUAS Elyes ehaouas@noos.fr
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38905 )
Change subject: mainboard: drop 5 broken ROMCC_BOOTBLOCK boards ......................................................................
Abandoned
Huge thanks to HAOUAS Elyes for completing this!
-
HAOUAS Elyes (Code Review) -
Mike Banon (Code Review)
-
Paul Menzel (Code Review)