Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30224 )
Change subject: superiotool: add IT8772F register dump ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/30224/1/util/superiotool/ite.c File util/superiotool/ite.c:
https://review.coreboot.org/c/coreboot/+/30224/1/util/superiotool/ite.c@856 PS1, Line 856: 0x30,0x60,0x61,0x70,0xf0,0xf1,EOT}, : {0x00,0x03,0xf8,0x04,0x00,0x50,EOT}},
the chip only has one serial port (don't know if the same die is used in a bigger package that has a […]
COM2 does not exist.
https://review.coreboot.org/c/coreboot/+/30224/1/util/superiotool/ite.c@865 PS1, Line 865: 0x08 WARNING: Table 8-4 incorrectly lists this value as 0x48! The register description marks the upper bits as RSVD and says they should be zero.
https://review.coreboot.org/c/coreboot/+/30224/1/util/superiotool/ite.c@874 PS1, Line 874: ,
It is not in my datasheet.
Oh, it actually is there? It only appears on the table, not on the register description...
I'll put it in just in case.
https://review.coreboot.org/c/coreboot/+/30224/1/util/superiotool/ite.c@877 PS1, Line 877: 0x03
0x01
Done
https://review.coreboot.org/c/coreboot/+/30224/1/util/superiotool/ite.c@878 PS1, Line 878: MISC
0x20
Ah, I know why I put MISC: one of the bits selected by means of strapping, so I was not sure if it mattered.
https://review.coreboot.org/c/coreboot/+/30224/1/util/superiotool/ite.c@880 PS1, Line 880: 0x00
0x40
There's differences between the table values and the register description value...
Table says 0x40, but register description says 0x00
In any case, looks like this bit is meaningless because GPIO46 is not supported.
https://review.coreboot.org/c/coreboot/+/30224/1/util/superiotool/ite.c@881 PS1, Line 881: 0x40
0x00
There's differences between the table values and the register description value...
Table says 0x00, but register description says 0x40
In any case, looks like this bit is meaningless because GPIO46 is not supported.
-
Angel Pons (Code Review)