Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45162 )
Change subject: mb/google/dedede/variants/drawcia: update PL2 value ......................................................................
mb/google/dedede/variants/drawcia: update PL2 value
Update PL2 (Power Limit2) value.
BRANCH=None BUG=b:166656373 TEST=Built and tested on drawlat system
Change-Id: I82d6792907bb1c88cc9dd57d1eaeda8421c12fb2 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/45162/1
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index faded0e..1157eb8 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -41,7 +41,7 @@
register "power_limits_config" = "{ .tdp_pl1_override = 6, - .tdp_pl2_override = 15, + .tdp_pl2_override = 20, }"
register "tcc_offset" = "20" # TCC of 85C @@ -75,7 +75,7 @@ .granularity = 200,}" register "controls.power_limits.pl2" = "{ .min_power = 6000, - .max_power = 15000, + .max_power = 20000, .time_window_min = 1 * MSECS_PER_SEC, .time_window_max = 1 * MSECS_PER_SEC, .granularity = 1000,}"
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45162 )
Change subject: mb/google/dedede/variants/drawcia: update PL2 value ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45162/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45162/1//COMMIT_MSG@7 PS1, Line 7: mb/google/dedede/variants/drawcia: update PL2 value Increase PL2 value from 15 to 20
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45162 )
Change subject: mb/google/dedede/variants/drawcia: update PL2 value ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45162/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45162/1//COMMIT_MSG@9 PS1, Line 9: Update PL2 (Power Limit2) value. … received from XXX.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45162
to look at the new patch set (#2).
Change subject: mb/google/dedede/variants/drawcia: Increase PL2 value from 15W to 20W ......................................................................
mb/google/dedede/variants/drawcia: Increase PL2 value from 15W to 20W
Jasper Lake SoC supports PL2 (Power Limit2) as 20W. Increase PL2 value from 15W to 20W.
BRANCH=None BUG=b:166656373 TEST=Built and tested on drawlat system
Change-Id: I82d6792907bb1c88cc9dd57d1eaeda8421c12fb2 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/45162/2
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45162 )
Change subject: mb/google/dedede/variants/drawcia: Increase PL2 value from 15W to 20W ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45162/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45162/1//COMMIT_MSG@7 PS1, Line 7: mb/google/dedede/variants/drawcia: update PL2 value
Increase PL2 value from 15 to 20
Done
https://review.coreboot.org/c/coreboot/+/45162/1//COMMIT_MSG@9 PS1, Line 9: Update PL2 (Power Limit2) value.
… received from XXX.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45162 )
Change subject: mb/google/dedede/variants/drawcia: Increase PL2 value from 15W to 20W ......................................................................
Patch Set 2: Code-Review+1
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45162 )
Change subject: mb/google/dedede/variants/drawcia: Increase PL2 value from 15W to 20W ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45162 )
Change subject: mb/google/dedede/variants/drawcia: Increase PL2 value from 15W to 20W ......................................................................
mb/google/dedede/variants/drawcia: Increase PL2 value from 15W to 20W
Jasper Lake SoC supports PL2 (Power Limit2) as 20W. Increase PL2 value from 15W to 20W.
BRANCH=None BUG=b:166656373 TEST=Built and tested on drawlat system
Change-Id: I82d6792907bb1c88cc9dd57d1eaeda8421c12fb2 Signed-off-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45162 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/drawcia/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb index 395dee3..fa10152 100644 --- a/src/mainboard/google/dedede/variants/drawcia/overridetree.cb +++ b/src/mainboard/google/dedede/variants/drawcia/overridetree.cb @@ -59,7 +59,7 @@
register "power_limits_config" = "{ .tdp_pl1_override = 6, - .tdp_pl2_override = 15, + .tdp_pl2_override = 20, }"
register "tcc_offset" = "20" # TCC of 85C @@ -93,7 +93,7 @@ .granularity = 200,}" register "controls.power_limits.pl2" = "{ .min_power = 6000, - .max_power = 15000, + .max_power = 20000, .time_window_min = 1 * MSECS_PER_SEC, .time_window_max = 1 * MSECS_PER_SEC, .granularity = 1000,}"
-
Karthik Ramasubramanian (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Sumeet R Pawnikar (Code Review)