Change in coreboot[master]: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus
Franklin (Yanjin) He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39600 )
Change subject: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus ......................................................................
src/mainboard/g/octopus: Enables GMM in the devicetree for octopus
As title suggests, adds GMM to the device tree for octopus devices
Change-Id: I75b4a835c18c5eeb542b7f7b89deea45a31e47bd Signed-off-by: Franklin He franklinh@google.com --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39600/1
diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index 8f85070..9f64a1e 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -112,6 +112,7 @@ device pci 00.2 off end # - NPK device pci 02.0 on end # - Gen device pci 03.0 on end # - Iunit + device pci 08.0 on end # - Gaussian Mixture Model (GMM) chip drivers/intel/wifi register "wake" = "GPE0A_CNVI_PME_STS" device pci 0c.0 on end # - CNVi
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39600 )
Change subject: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39600/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39600/1//COMMIT_MSG@9 PS1, Line 9: As title suggests, adds GMM to the device tree for octopus devices You need BUG/BRANCH/TEST lines. Also add the board owner as the reviewer.
Hello build bot (Jenkins), Furquan Shaikh, Edward O'Callaghan, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39600
to look at the new patch set (#2).
Change subject: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus ......................................................................
src/mainboard/g/octopus: Enables GMM in the devicetree for octopus
As title suggests, adds GMM to the device tree for octopus devices Related to Gerrit review 39579
BUG=b:151115705 BRANCH=None TEST=Flashed final image on Chromebook
Change-Id: I75b4a835c18c5eeb542b7f7b89deea45a31e47bd Signed-off-by: Franklin He franklinh@google.com --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39600/2
Franklin (Yanjin) He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39600 )
Change subject: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39600/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39600/1//COMMIT_MSG@9 PS1, Line 9: As title suggests, adds GMM to the device tree for octopus devices
You need BUG/BRANCH/TEST lines. Also add the board owner as the reviewer.
Commit msg changed & Karthik has been added as a reviewer
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39600 )
Change subject: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus ......................................................................
Patch Set 3: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Edward O'Callaghan, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39600
to look at the new patch set (#4).
Change subject: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus ......................................................................
src/mainboard/g/octopus: Enables GMM in the devicetree for octopus
Adds GMM into the baseboard of Octopus For GLK, PCI device 3 is GMM according to Document#: 569262(Glk EDS Vol-1 rev2-7)
Related to Gerrit review 39579
BUG=b:151115705 BRANCH=None TEST=Flashed final image on Chromebook
Change-Id: I75b4a835c18c5eeb542b7f7b89deea45a31e47bd Signed-off-by: Franklin He franklinh@google.com --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/39600/4
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39600 )
Change subject: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39600 )
Change subject: src/mainboard/g/octopus: Enables GMM in the devicetree for octopus ......................................................................
src/mainboard/g/octopus: Enables GMM in the devicetree for octopus
Adds GMM into the baseboard of Octopus For GLK, PCI device 3 is GMM according to Document#: 569262(Glk EDS Vol-1 rev2-7)
Related to Gerrit review 39579
BUG=b:151115705 BRANCH=None TEST=Flashed final image on Chromebook
Change-Id: I75b4a835c18c5eeb542b7f7b89deea45a31e47bd Signed-off-by: Franklin He franklinh@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39600 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/octopus/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb index 8f85070..5404531 100644 --- a/src/mainboard/google/octopus/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/octopus/variants/baseboard/devicetree.cb @@ -111,7 +111,7 @@ device pci 00.1 on end # - DPTF device pci 00.2 off end # - NPK device pci 02.0 on end # - Gen - device pci 03.0 on end # - Iunit + device pci 03.0 on end # - Gaussian Mixture Model (GMM) chip drivers/intel/wifi register "wake" = "GPE0A_CNVI_PME_STS" device pci 0c.0 on end # - CNVi
-
Edward O'Callaghan (Code Review) -
Franklin (Yanjin) He (Code Review)
-
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)