[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add thermal driver - coreboot-gerrit

17 Jan 2025


      Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86017?usp=email )
Change subject: soc/mediatek/mt8196: Add thermal driver
......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/mt8196/thermal.c:
https://review.coreboot.org/c/coreboot/+/86017/comment/d60be1b1_5a1d0054?usp... :
PS4, Line 324: 	op_cali[LVTS_AP_CONTROLLER0] = temp[5] & GENMASK(29, 24) >> 24;
...
...
`Possible precedence defect with mask then right shift - may need parentheses` […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/86017?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieef94a6909e4da82461351bcb9292e9d01db3362
Gerrit-Change-Number: 86017
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: Zhaoqing Jiu zhaoqing.jiu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 11:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com