Attention is currently required from: Julius Werner, Jan Dabros. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51804 )
Change subject: include/assert.h: Use mock_assert() for ENV_TEST targets ......................................................................
Patch Set 4:
(3 comments)
File src/include/assert.h:
https://review.coreboot.org/c/coreboot/+/51804/comment/f509ddf3_138a576e PS3, Line 12: const char *const file, const int line);
nit: maybe declare this right next to MOCK_ASSERT() so it's more obvious where it belongs to?
Good point. Done :)
https://review.coreboot.org/c/coreboot/+/51804/comment/0acb1bd9_9bae5217 PS3, Line 38: mock_assert((result), (expression), (file), (line))
You can just use __ASSERT_FILE__ and __ASSERT_LINE__ in here, no need to pass so many things.
Sure, less arguments, same result :)
https://review.coreboot.org/c/coreboot/+/51804/comment/7160fa79_b7f24a15 PS3, Line 71: MOCK_ASSERT(0, "BUG ENCOUNTERED", \
Bad indentation.
Done
-
Jakub Czapiga (Code Review)