Change in coreboot[master]: sb,soc/intel: Refactor power_on_after_fail option - coreboot-gerrit

9 Jan 2021


      Attention is currently required from: Patrick Rudolph.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49251 )
Change subject: sb,soc/intel: Refactor power_on_after_fail option
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
...
why is this in SMM at all? other platforms set the bits as part of the soc init code in ramstage.
Supposedly changing CMOS with nvramtool takes immediate effect this way and does not require reboot.
I should move the inline comments about this, though.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49251
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic821b429a58a2c0713ec338904364ec57bfbcfce
Gerrit-Change-Number: 49251
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sat, 09 Jan 2021 17:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Gerrit-MessageType: comment