HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32444
Change subject: mb/siemens/mc_apl1: Remove unneeded white space ......................................................................
mb/siemens/mc_apl1: Remove unneeded white space
Change-Id: Icc9718f0d15c9393c1c3172747359af087054277 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/32444/1
diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb index 50207e0..d8d6fe5 100644 --- a/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb +++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb @@ -88,7 +88,7 @@ device pci 1c.0 on end # - eMMC device pci 1d.0 off end # - UFS device pci 1e.0 off end # - SDIO - device pci 1f.0 on # - LPC + device pci 1f.0 on # - LPC chip drivers/pc80/tpm device pnp 0c31.0 on end end
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32444 )
Change subject: mb/siemens/mc_apl1: Remove unneeded white space ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/32444/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb:
https://review.coreboot.org/#/c/32444/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 91: device pci 1f.0 on # - LPC This two whitespace are on purpose to align the comments of each line. So if you are against it than you have to add a tab instead to keep comments aligned. I would vote for keeping it as it is if you do not mind. You can find these witespace in a few more lines above.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32444 )
Change subject: mb/siemens/mc_apl1: Remove unneeded white space ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32444/1/src/mainboard/siemens/mc_apl1/varian... File src/mainboard/siemens/mc_apl1/variants/mc_apl4/devicetree.cb:
https://review.coreboot.org/#/c/32444/1/src/mainboard/siemens/mc_apl1/varian... PS1, Line 91: device pci 1f.0 on # - LPC
This two whitespace are on purpose to align the comments of each line. […]
Thank you for the review. this 2 whitespaces are just before a tab and removing them will not affect the alignment.
Note that I'm also fine to keep them :))
Please let me know your thought.
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32444 )
Change subject: mb/siemens/mc_apl1: Remove unneeded white space ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Werner Zeh (Code Review)