build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25752 )
Change subject: soc/cavium: Add secondary CPU support ......................................................................
Patch Set 15:
(6 comments)
https://review.coreboot.org/#/c/25752/15/src/mainboard/cavium/cn8100_sff_evb... File src/mainboard/cavium/cn8100_sff_evb/mainboard.c:
https://review.coreboot.org/#/c/25752/15/src/mainboard/cavium/cn8100_sff_evb... PS15, Line 70: printk(BIOS_INFO, "MB: #CPU cores : %zu\n", cpu_get_num_available_cores()); line over 80 characters
https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c File src/soc/cavium/cn81xx/cpu.c:
https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c@35 PS15, Line 35: static void (* secondary_c_entry)(size_t core_id) = NULL; Unnecessary space before function pointer name
https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c@35 PS15, Line 35: static void (* secondary_c_entry)(size_t core_id) = NULL; space prohibited after that '*' (ctx:BxW)
https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c@67 PS15, Line 67: size_t start_cpu(size_t cpu, void (* entry_64)(size_t core_id)) space prohibited after that '*' (ctx:BxW)
https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/cpu.c@121 PS15, Line 121: while (!stopwatch_expired(&sw) && !read64(&secondary_booted)); trailing statements should be on next line
https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/include/soc/c... File src/soc/cavium/cn81xx/include/soc/cpu.h:
https://review.coreboot.org/#/c/25752/15/src/soc/cavium/cn81xx/include/soc/c... PS15, Line 47: size_t start_cpu(size_t cpu, void (* entry_64)(size_t core_id)); space prohibited after that '*' (ctx:BxW)
-
build bot (Jenkins) (Code Review)