Attention is currently required from: Dtrain Hsu, Nick Vaccaro, Zhuohao Lee. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62625 )
Change subject: mb/google/brya/var/kinox: Modify the DPTF/Fan parameters ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62625/comment/bc8c2330_c7d7743f PS5, Line 9: Follow the Thermal_paramters_list v1.0 to modify DPTF/Fan parameters Please add more details here based on the code changes and who suggested those values.
File src/mainboard/google/brya/variants/kinox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62625/comment/1a7d2a30_4e9dc7ae PS5, Line 139: 90, SHUTDOWN), : [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 90, SHUTDOWN), : [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 90, SHUTDOWN), : [4] = DPTF_CRITICAL(TEMP_SENSOR_3, 90 Is there any specific reason for keeping the same 90 degree C temperature threshold for both Critical and Passive policies for all TSR0/1/2/3 sensors ? Normally Critical temperature thresholds are higher than Passive ones.
-
Sumeet R Pawnikar (Code Review)