Attention is currently required from: Tim Crawford, Tim Wawrzynczak, Nick Vaccaro.
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62381 )
Change subject: drivers/gfx/nvidia: Add basic Nvidia GPU driver
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
File src/drivers/gfx/nvidia/gpu.asl:
https://review.coreboot.org/c/coreboot/+/62381/comment/cbf1063f_c3073ecd
PS2, Line 34: Name (G6XS, 0)
This value does not appear to actually be used. It is critical that the JT DSM is provided, and that this DSM is used to determine if the reset line of the GPU should be toggled, or both the reset and power lines, when the GPU enters D3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62381
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib02664568c47ef5615673be1043f50cc28b0d552
Gerrit-Change-Number: 62381
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Fri, 04 Mar 2022 15:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment