Attention is currently required from: Andy Pont, Paul Menzel, Angel Pons, Felix Held.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support
......................................................................
Patch Set 40:
(2 comments)
File src/ec/starlabs/merlin/Kconfig:
https://review.coreboot.org/c/coreboot/+/58343/comment/0ea66016_86b079f0
PS37, Line 22: bool "Adjustable Keyboard Backlight"
If it's not meant to be user-configurable, the prompt (text after `bool`) should be removed.
Done
File src/ec/starlabs/merlin/ec.c:
https://review.coreboot.org/c/coreboot/+/58343/comment/c5845f6a_7b8753be
PS19, Line 134: #if CONFIG(EC_STARLABS_FAN)
: switch (get_uint_option("fan_mode", 0)) {
: case FAN_AGGRESSIVE:
: ec_write(ECRAM_FAN_MODE, FAN_AGGRESSIVE);
: break;
: case FAN_QUIET:
: ec_write(ECRAM_FAN_MODE, FAN_QUIET);
: break;
: default:
: ec_write(ECRAM_FAN_MODE, FAN_NORMAL);
: break;
: }
: #endif
Ah, I see. Then, you should do the following: […]
That's very cool, thanks :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8023c26de23c874c84106fda96e64dcfa0c5ba32
Gerrit-Change-Number: 58343
Gerrit-PatchSet: 40
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andy Pont
andy.pont@sdcsystems.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 15 Nov 2021 22:09:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment