build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39111 )
Change subject: soc/intel/tigerlake: Add Jasper lake GPIO support ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39111/3/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/gpio_soc_defs_jsl.h:
https://review.coreboot.org/c/coreboot/+/39111/3/src/soc/intel/tigerlake/inc... PS3, Line 25: #define GPP_F 0x9 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39111/3/src/soc/intel/tigerlake/inc... PS3, Line 26: #define GPP_G 0x2 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39111/3/src/soc/intel/tigerlake/inc... PS3, Line 28: #define GPP_A 0x0 please, no space before tabs