Attention is currently required from: Patrick Rudolph, Simon Chou, Johnny Lin, Christian Walter, Shuming Chu (Shuming), Arthur Heymans.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71967 )
Change subject: soc/intel/xeon_sp/spr: add ACPI code
......................................................................
Patch Set 13:
(2 comments)
File src/soc/intel/xeon_sp/spr/acpi/uncore.asl:
https://review.coreboot.org/c/coreboot/+/71967/comment/b6444edc_fe63a8e6
PS13, Line 38: #if (CONFIG_MAX_SOCKET > 3)
This part of the DSDT code should be generated, using hob->PlatformData.numofIIO.
File src/soc/intel/xeon_sp/spr/soc_acpi.c:
https://review.coreboot.org/c/coreboot/+/71967/comment/f3b8a959_5d348b60
PS13, Line 387: for (uint8_t socket = 0; socket < hob->PlatformData.numofIIO; ++socket) {
The issue is that SSDT needs to be in sync with DSDT (src/soc/intel/xeon_sp/spr/acpi/uncore. […]
Got you. I think we should use hob->PlatformData.numofIIO for DSDT as well; in other words, we should generate that part of the DSDT code. Do you agree?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71967
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2a9be0222e122ae087b9cc8e1859d257e3411d6
Gerrit-Change-Number: 71967
Gerrit-PatchSet: 13
Gerrit-Owner: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 01 Feb 2023 21:46:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment