Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33377 )
Change subject: soc/intel/common/block/xhci: Add API to disable USB devices
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33377/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33377/4//COMMIT_MSG@7
PS4, Line 7: mb/google/octopus
soc/intel/common:
Done
https://review.coreboot.org/c/coreboot/+/33377/4/src/soc/intel/common/block/...
File src/soc/intel/common/block/xhci/xhci.c:
https://review.coreboot.org/c/coreboot/+/33377/4/src/soc/intel/common/block/...
PS4, Line 99: ext_usb_xhci_en_cb
Do you think there is value in allowing mainboard to pass in a NULL for this so that all external po […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33377
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied12faabee1b8c096f2b27de89ab42ee8be5d94d
Gerrit-Change-Number: 33377
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 15:45:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment