HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44290 )
Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ......................................................................
sb/intel/bd82x6x/smbus.c: Remove dead assignment
Change-Id: I91d4f925803aaceea8a5c5d0d4e2c44a6b135aec Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/bd82x6x/smbus.c 1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/44290/1
diff --git a/src/southbridge/intel/bd82x6x/smbus.c b/src/southbridge/intel/bd82x6x/smbus.c index 7a00cf4..b8d7d31 100644 --- a/src/southbridge/intel/bd82x6x/smbus.c +++ b/src/southbridge/intel/bd82x6x/smbus.c @@ -65,9 +65,6 @@ res->limit = res->base + res->size - 1; res->flags = IORESOURCE_IO | IORESOURCE_FIXED | IORESOURCE_RESERVE | IORESOURCE_STORED | IORESOURCE_ASSIGNED; - - /* Also add MMIO resource */ - res = pci_get_resource(dev, PCI_BASE_ADDRESS_0); }
static const char *smbus_acpi_name(const struct device *dev)
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44290 )
Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44290/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smbus.c:
https://review.coreboot.org/c/coreboot/+/44290/1/src/southbridge/intel/bd82x... PS1, Line 70: pci_get_resource You also remove pci_get_resource
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44290 )
Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44290/1/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/smbus.c:
https://review.coreboot.org/c/coreboot/+/44290/1/src/southbridge/intel/bd82x... PS1, Line 70: pci_get_resource
You also remove pci_get_resource
indeed, thank you.
why don't we also use pci_get_resource for i82801gx/smbus.c
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44290 )
Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ......................................................................
Patch Set 1: Code-Review-1
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44290 )
Change subject: sb/intel/bd82x6x/smbus.c: Remove dead assignment ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review) -
Patrick Rudolph (Code Review)