Change in coreboot[master]: mb/google/octopus: Fix unused pins and those with external terminations
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27183 )
Change subject: mb/google/octopus: Fix unused pins and those with external terminations ......................................................................
Patch Set 2:
(29 comments)
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 96: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 131: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 133: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 134: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 137: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 141: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 166: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 175: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 198: PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 203: PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 226: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_164, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* WLAN_PE_RST */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 228: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 249: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* EMMC0_CLK */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 259: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... File src/mainboard/google/octopus/variants/bip/gpio.c:
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 94: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_67, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* UART2-CTS_B -- EN_PP3300_DX_LTE_SOC */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 136: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 138: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 139: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 142: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 146: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 171: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 177: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_120, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ0_B -- unused */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 180: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 204: PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 205: PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 210: PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 234: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 255: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* EMMC0_CLK */ line over 80 characters
https://review.coreboot.org/#/c/27183/2/src/mainboard/google/octopus/variant... PS2, Line 265: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */ line over 80 characters
-
build bot (Jenkins) (Code Review)