Change in coreboot[master]: nb/intel/haswell: Drop none reliable MCHBARx_AND_OR macro

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44458 )

Change subject: nb/intel/haswell: Drop none reliable MCHBARx_AND_OR macro
......................................................................

nb/intel/haswell: Drop none reliable MCHBARx_AND_OR macro

Change-Id: Ib32f91de325a2291801807cdb2a887e18f08f102
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/haswell/haswell.h
1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44458/1

diff --git a/src/northbridge/intel/haswell/haswell.h b/src/northbridge/intel/haswell/haswell.h
index 9a99c2a..db343fd 100644
--- a/src/northbridge/intel/haswell/haswell.h
+++ b/src/northbridge/intel/haswell/haswell.h
@@ -50,9 +50,6 @@
 #define MCHBAR8_OR(x,  or) (MCHBAR8(x)  = MCHBAR8(x)  | (or))
 #define MCHBAR16_OR(x, or) (MCHBAR16(x) = MCHBAR16(x) | (or))
 #define MCHBAR32_OR(x, or) (MCHBAR32(x) = MCHBAR32(x) | (or))
-#define MCHBAR8_AND_OR(x,  and, or) (MCHBAR8(x)  = (MCHBAR8(x)  & (and)) | (or))
-#define MCHBAR16_AND_OR(x, and, or) (MCHBAR16(x) = (MCHBAR16(x) & (and)) | (or))
-#define MCHBAR32_AND_OR(x, and, or) (MCHBAR32(x) = (MCHBAR32(x) & (and)) | (or))

/* As there are many registers, define them on a separate file */
 #include "mchbar_regs.h"

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44458

to look at the new patch set (#2).

Change subject: nb/intel/haswell: Drop none reliable MCHBARx_AND_OR macro
......................................................................

nb/intel/haswell: Drop none reliable MCHBARx_AND_OR macro

Use of MCHBARx_AND_OR gives an error:
 overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow]

Change-Id: Ib32f91de325a2291801807cdb2a887e18f08f102
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/haswell/haswell.h
1 file changed, 0 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44458/2

Change in coreboot[master]: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Angel Pons, Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44458

to look at the new patch set (#3).

Change subject: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros
......................................................................

nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

Use of MCHBARx_AND_OR gives an error:
 overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow]

Change-Id: Ib32f91de325a2291801807cdb2a887e18f08f102
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/haswell/finalize.c
M src/northbridge/intel/haswell/haswell.h
2 files changed, 7 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44458/3

Change in coreboot[master]: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Angel Pons, Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44458

to look at the new patch set (#4).

Change subject: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros
......................................................................

nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

Use of MCHBARx_AND_OR gives an error:
 overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow]

Change-Id: Ib32f91de325a2291801807cdb2a887e18f08f102
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/haswell/finalize.c
M src/northbridge/intel/haswell/haswell.h
M src/northbridge/intel/pineview/pineview.h
3 files changed, 7 insertions(+), 25 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44458/4

Change in coreboot[master]: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Damien Zammit, Angel Pons, Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44458

to look at the new patch set (#5).

Change subject: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros
......................................................................

nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

Use of MCHBARx_AND_OR gives an error:
 overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow]

Change-Id: Ib32f91de325a2291801807cdb2a887e18f08f102
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/haswell/finalize.c
M src/northbridge/intel/haswell/haswell.h
2 files changed, 7 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44458/5

Change in coreboot[master]: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Damien Zammit, Angel Pons, Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44458

to look at the new patch set (#6).

Change subject: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros
......................................................................

nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

Use of MCHBARx_AND_OR gives an error:
 overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow]

Change-Id: Ib32f91de325a2291801807cdb2a887e18f08f102
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/haswell/finalize.c
M src/northbridge/intel/haswell/haswell.h
2 files changed, 7 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44458/6

Change in coreboot[master]: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44458 )

Change subject: nb/intel/haswell: Drop none reliable MCHBARx_{AND,OR} macros
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44458/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44458/8//COMMIT_MSG@7 
PS8, Line 7: none reliable
unreliable?

Change in coreboot[master]: nb/intel/haswell: Drop unreliable MCHBARx_{AND,OR} macros

[HAOUAS Elyes (Code Review)]

Hello build bot (Jenkins), Nico Huber, Damien Zammit, Angel Pons, Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44458

to look at the new patch set (#9).

Change subject: nb/intel/haswell: Drop unreliable MCHBARx_{AND,OR} macros
......................................................................

nb/intel/haswell: Drop unreliable MCHBARx_{AND,OR} macros

Use of MCHBARx_AND_OR gives an error:
 overflow in conversion from 'int' to 'u16' {aka 'volatile short unsigned int'} changes value from '(int)*(volatile u16 *)((unsigned int)((int)i * 1024) + 4275127072) & -65536 | 26214' to '26214' [-Werror=overflow]

Change-Id: Ib32f91de325a2291801807cdb2a887e18f08f102
Signed-off-by: Elyes HAOUAS 
---
M src/northbridge/intel/haswell/finalize.c
M src/northbridge/intel/haswell/haswell.h
2 files changed, 7 insertions(+), 16 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/44458/9

Change in coreboot[master]: nb/intel/haswell: Drop unreliable MCHBARx_{AND,OR} macros

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44458 )

Change subject: nb/intel/haswell: Drop unreliable MCHBARx_{AND,OR} macros
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44458/8//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/44458/8//COMMIT_MSG@7 
PS8, Line 7: none reliable
> unreliable?

Thank you.

Change in coreboot[master]: nb/intel/haswell: Drop unreliable MCHBARx_{AND,OR} macros

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44458 )

Change subject: nb/intel/haswell: Drop unreliable MCHBARx_{AND,OR} macros
......................................................................

Abandoned

see 42448