Change in coreboot[master]: security/vboot: Add const modifier to vb2api_relocate argument
Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37232 )
Change subject: security/vboot: Add const modifier to vb2api_relocate argument ......................................................................
security/vboot: Add const modifier to vb2api_relocate argument
BRANCH=none BUG=none TEST=emerge-nami vboot_reference coreboot
Cq-Depend: chromium:1935272 Change-Id: I599262586f30b6768e394bd9795d4e52269f4fdf Signed-off-by: Yu-Ping Wu yupingso@chromium.org --- M src/security/vboot/common.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/37232/1
diff --git a/src/security/vboot/common.c b/src/security/vboot/common.c index cb4c569..11a5189 100644 --- a/src/security/vboot/common.c +++ b/src/security/vboot/common.c @@ -92,7 +92,7 @@ static void vboot_migrate_cbmem(int unused) { const size_t cbmem_size = VB2_KERNEL_WORKBUF_RECOMMENDED_SIZE; - void *wb_preram = (void *)_vboot2_work; + const void *wb_preram = (void *)_vboot2_work; void *wb_cbmem = cbmem_add(CBMEM_ID_VBOOT_WORKBUF, cbmem_size); assert(wb_cbmem != NULL); vb2api_relocate(wb_cbmem, wb_preram, cbmem_size,
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37232 )
Change subject: security/vboot: Add const modifier to vb2api_relocate argument ......................................................................
Patch Set 2:
Note that this patch is dependent on vboot.
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37232 )
Change subject: security/vboot: Add const modifier to vb2api_relocate argument ......................................................................
Patch Set 2: Code-Review+2
LGTM, but will need to commit to Chromium repo first, and uprev the vboot submodule in this CL, as we discussed offline.
Hello Aaron Durbin, build bot (Jenkins), Joel Kitching,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37232
to look at the new patch set (#3).
Change subject: security/vboot: Add const modifier to vb2api_relocate argument ......................................................................
security/vboot: Add const modifier to vb2api_relocate argument
BRANCH=none BUG=none TEST=emerge-nami vboot_reference coreboot
Cq-Depend: chromium:1935272 Change-Id: I599262586f30b6768e394bd9795d4e52269f4fdf Signed-off-by: Yu-Ping Wu yupingso@chromium.org --- M src/security/vboot/common.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/37232/3
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37232 )
Change subject: security/vboot: Add const modifier to vb2api_relocate argument ......................................................................
Patch Set 3: Code-Review+2
Yu-Ping Wu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37232 )
Change subject: security/vboot: Add const modifier to vb2api_relocate argument ......................................................................
Abandoned
Becomes empty after rebasing
-
Joel Kitching (Code Review) -
Yu-Ping Wu (Code Review)