Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48750 )
Change subject: mb/clevo/l140cu: add panel settings to the dt and hook up GMA ACPI
......................................................................
Patch Set 34:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48750/34//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48750/34//COMMIT_MSG@12
PS34, Line 12: Brightness control still requires ACPI code to link the EC events to it.
: This will be done in a separate change later.
is this still true? the parent commit should be sufficient, no?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7977a2271da72c142b025b4631318d1a39adfb13
Gerrit-Change-Number: 48750
Gerrit-PatchSet: 34
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Jan 2021 20:53:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment