Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47981 )
Change subject: mb/google/volteer/variant/copano: Add memory part support ......................................................................
mb/google/volteer/variant/copano: Add memory part support
Add support for the following 5 LPDDR4x memory parts: - MT53E512M64D4NW-046 WT:E - H9HCNNNCRMBLPR-NEE - MT53D1G64D4NW-046 WT:A - H9HCNNNFBMBLPR-NEE - MT53D512M64D4NW-046 WT:F
BUG=b:172993397 TEST=none
Change-Id: Iff8f6257c6cff77fc3f0bda7e75434f9f4de1777 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/copano/memory/Makefile.inc A src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt 3 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/47981/1
diff --git a/src/mainboard/google/volteer/variants/copano/memory/Makefile.inc b/src/mainboard/google/volteer/variants/copano/memory/Makefile.inc new file mode 100644 index 0000000..4a7f1d7 --- /dev/null +++ b/src/mainboard/google/volteer/variants/copano/memory/Makefile.inc @@ -0,0 +1,8 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M64D4NW-046 WT:E, H9HCNNNCRMBLPR-NEE +SPD_SOURCES += lp4x-spd-4.hex # ID = 1(0b0001) Parts = MT53D1G64D4NW-046 WT:A +SPD_SOURCES += lp4x-spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNFBMBLPR-NEE +SPD_SOURCES += lp4x-spd-6.hex # ID = 3(0b0011) Parts = MT53D512M64D4NW-046 WT:F diff --git a/src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt new file mode 100644 index 0000000..5dc1ebd --- /dev/null +++ b/src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt @@ -0,0 +1,6 @@ +DRAM Part Name ID to assign +MT53E512M64D4NW-046 WT:E 0 (0000) +H9HCNNNCRMBLPR-NEE 0 (0000) +MT53D1G64D4NW-046 WT:A 1 (0001) +H9HCNNNFBMBLPR-NEE 2 (0010) +MT53D512M64D4NW-046 WT:F 3 (0011) diff --git a/src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt new file mode 100644 index 0000000..4afc390 --- /dev/null +++ b/src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt @@ -0,0 +1,5 @@ +MT53E512M64D4NW-046 WT:E +H9HCNNNCRMBLPR-NEE +MT53D1G64D4NW-046 WT:A +H9HCNNNFBMBLPR-NEE +MT53D512M64D4NW-046 WT:F
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47981 )
Change subject: mb/google/volteer/variant/copano: Add memory part support ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47981 )
Change subject: mb/google/volteer/variant/copano: Add memory part support ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Tim Wawrzynczak, Tim Wawrzynczak, Alan Chuang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47981
to look at the new patch set (#2).
Change subject: mb/google/volteer/variant/copano: Add memory part support ......................................................................
mb/google/volteer/variant/copano: Add memory part support
Add support for the following 5 LPDDR4x memory parts: - MT53E512M64D4NW-046 WT:E - H9HCNNNCRMBLPR-NEE - MT53D1G64D4NW-046 WT:A - H9HCNNNFBMBLPR-NEE - MT53D512M64D4NW-046 WT:F
DRAM Part Name ID to assign ------------------------------------------- MT53E512M64D4NW-046 WT:E 0 (0000) H9HCNNNCRMBLPR-NEE 0 (0000) MT53D1G64D4NW-046 WT:A 1 (0001) H9HCNNNFBMBLPR-NEE 2 (0010) MT53D512M64D4NW-046 WT:F 0 (0000)
BUG=b:172993397 TEST=none
Change-Id: Iff8f6257c6cff77fc3f0bda7e75434f9f4de1777 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/copano/memory/Makefile.inc A src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt 3 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/47981/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47981 )
Change subject: mb/google/volteer/variant/copano: Add memory part support ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47981 )
Change subject: mb/google/volteer/variant/copano: Add memory part support ......................................................................
mb/google/volteer/variant/copano: Add memory part support
Add support for the following 5 LPDDR4x memory parts: - MT53E512M64D4NW-046 WT:E - H9HCNNNCRMBLPR-NEE - MT53D1G64D4NW-046 WT:A - H9HCNNNFBMBLPR-NEE - MT53D512M64D4NW-046 WT:F
DRAM Part Name ID to assign ------------------------------------------- MT53E512M64D4NW-046 WT:E 0 (0000) H9HCNNNCRMBLPR-NEE 0 (0000) MT53D1G64D4NW-046 WT:A 1 (0001) H9HCNNNFBMBLPR-NEE 2 (0010) MT53D512M64D4NW-046 WT:F 0 (0000)
BUG=b:172993397 TEST=none
Change-Id: Iff8f6257c6cff77fc3f0bda7e75434f9f4de1777 Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47981 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/volteer/variants/copano/memory/Makefile.inc A src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt 3 files changed, 18 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/copano/memory/Makefile.inc b/src/mainboard/google/volteer/variants/copano/memory/Makefile.inc new file mode 100644 index 0000000..511ab5b --- /dev/null +++ b/src/mainboard/google/volteer/variants/copano/memory/Makefile.inc @@ -0,0 +1,7 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M64D4NW-046 WT:E, H9HCNNNCRMBLPR-NEE, MT53D512M64D4NW-046 WT:F +SPD_SOURCES += lp4x-spd-4.hex # ID = 1(0b0001) Parts = MT53D1G64D4NW-046 WT:A +SPD_SOURCES += lp4x-spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNFBMBLPR-NEE diff --git a/src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt new file mode 100644 index 0000000..a8b78f5 --- /dev/null +++ b/src/mainboard/google/volteer/variants/copano/memory/dram_id.generated.txt @@ -0,0 +1,6 @@ +DRAM Part Name ID to assign +MT53E512M64D4NW-046 WT:E 0 (0000) +H9HCNNNCRMBLPR-NEE 0 (0000) +MT53D1G64D4NW-046 WT:A 1 (0001) +H9HCNNNFBMBLPR-NEE 2 (0010) +MT53D512M64D4NW-046 WT:F 0 (0000) diff --git a/src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt new file mode 100644 index 0000000..4afc390 --- /dev/null +++ b/src/mainboard/google/volteer/variants/copano/memory/mem_list_variant.txt @@ -0,0 +1,5 @@ +MT53E512M64D4NW-046 WT:E +H9HCNNNCRMBLPR-NEE +MT53D1G64D4NW-046 WT:A +H9HCNNNFBMBLPR-NEE +MT53D512M64D4NW-046 WT:F
-
Caveh Jalali (Code Review) -
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)