Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74769 )
Change subject: soc/intel/meteorlake: Add support of crashlog ......................................................................
Patch Set 2:
(3 comments)
File src/soc/intel/common/block/include/intelblocks/crashlog.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174967): https://review.coreboot.org/c/coreboot/+/74769/comment/499e14e5_0e4e1599 PS2, Line 76: u32 discov_mechanism :2; /* CrashLog discovery mechanism */ please, no space before tabs
File src/soc/intel/meteorlake/crashlog.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174967): https://review.coreboot.org/c/coreboot/+/74769/comment/7d4ca6a1_da89ef73 PS2, Line 262: if (pci_read_config16(PCI_DEV_IOE_SRAM, PCI_VENDOR_ID) == 0xFFFF) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-174967): https://review.coreboot.org/c/coreboot/+/74769/comment/62f44df1_254fc1ef PS2, Line 262: if (pci_read_config16(PCI_DEV_IOE_SRAM, PCI_VENDOR_ID) == 0xFFFF) { please, no spaces at the start of a line